Re: [PATCH v2 0/5] add s390 support to nolibc and rcutorture

Willy Tarreau
2023-01-02T14:33:27Z

On Mon, Jan 02, 2023 at 03:19:10PM +0100, Sven Schnelle wrote:
> Willy Tarreau <w@1wt.eu> writes:
>
> > On Mon, Jan 02, 2023 at 11:51:07AM +0100, Sven Schnelle wrote:
> >> Hi,
> >>
> >> these patches add support for the s390 architecture both to nolibc
> >> and rcutorture. Note that this only adds support for the 64 bit
> >> version, no support for 31 bit (compat) is added. For nolibc it
> >> includes one bugfix to make the fd_set datatype match the kernel
> >> type.
> >>
> >> Changes in v2:
> >>
> >> - use __attribute__((unused)) instead of __maybe_unused
> >> - prefer aghi over lay, as lay is not present in all architecure levels
> >> - add -m64 CFLAG to force 64 bit mode for compiler that can do 31bit and 64bit mode
> >
> > Excellent, now works out of the box for me, thank you Sven!.
> >
> > Paul, would you mind taking these ones for your dev branch instead
> > of the previous ones ?
>
> Hrm, while looking at the code to make the adjustments for the auxv
> stuff, i noted that the envp handling in the startup code is wrong. So i
> have to fix that and send a v3 of the patchset.

OK thank you for letting us know!

Willy