Re: [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

Jason Gunthorpe
2023-02-28T12:31:12Z

On Tue, Feb 28, 2023 at 06:58:38AM +0000, Liu, Yi L wrote:

> Seems like pt_id is no more needed in the vfio_iommufd_bind()
> since it can get compat_ioas_id in the function itself. Cdev path
> never passes a pt_id to vfio_iommufd_bind() as its attach is done
> by separate ATTACH ioctl. Can we use the dev_id pointer to indicate
> if it needs to get the compat ioas and attach it?

In this case you need to split the group code to also use the two step
attach and then the attach will take in the null pt_id.

Jason