Re: [PATCH v5 14/19] vfio: Make vfio_device_open() single open for device cdev path

Jason Gunthorpe
2023-02-28T12:33:55Z

On Tue, Feb 28, 2023 at 03:11:34AM +0000, Liu, Yi L wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Tuesday, February 28, 2023 2:52 AM
> >
> > On Mon, Feb 27, 2023 at 03:11:30AM -0800, Yi Liu wrote:
> > > @@ -535,7 +542,8 @@ static int vfio_device_fops_release(struct inode
> > *inode, struct file *filep)
> > > struct vfio_device_file *df = filep->private_data;
> > > struct vfio_device *device = df->device;
> > >
> > > - vfio_device_group_close(df);
> > > + if (!df->is_cdev_device)
> > > + vfio_device_group_close(df);
> >
> > This hunk should go in another patch
>
> Patch 15 or 16? Which one is your preference? To me, I guess patch
> 15 is better since the user may open cdev fds after it. But its release
> op should not call vfio_device_group_close();

It should go with the patch that allows creating the struct file
withotu calling vfio_device_group_open()

Jason