Re: [PATCH v2 1/6] riscv/mm/fault: simplify code for do_page_fault()

Matthew Wilcox
2023-03-15T05:02:53Z

On Tue, Mar 14, 2023 at 08:03:54PM -0700, Palmer Dabbelt wrote:
> To make the code more hierarchical and readable, we fold vma related
> judgments into __do_page_fault(). And to simplify the code, move the
> tsk->thread.bad_cause's setting into bad_area(). No functional change
> intended.

I think this is exaactly the wrong thing to be doing. Please _stop_
using custom internal VM_FAULT flags, not adding new uses!