RE: [PATCH v7 15/22] vfio-iommufd: Add detach_ioas support for physical VFIO devices

Tian, Kevin
2023-03-17T02:14:10Z

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, March 16, 2023 8:55 PM
>
> +void vfio_iommufd_physical_detach_ioas(struct vfio_device *vdev)
> +{
> + lockdep_assert_held(&vdev->dev_set->lock);
> +
> + if (WARN_ON(!vdev->iommufd_device) || !vdev->iommufd_attached)
> + return;
> +

the 2nd check shouldn't be a WARN_ON. It's user-triggerable.