RE: [PATCH v3 01/12] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset()

Liu, Yi L
2023-04-04T14:38:01Z

> From: Eric Auger <eric.auger@redhat.com>
> Sent: Tuesday, April 4, 2023 10:00 PM
>
> Hi Yi,
>
> On 4/1/23 16:44, Yi Liu wrote:
> > this suits more on what the code does.
> >
> > Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> > Tested-by: Yanting Jiang <yanting.jiang@intel.com>
> > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > ---
> > drivers/vfio/pci/vfio_pci_core.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
> > index a5ab416cf476..65bbef562268 100644
> > --- a/drivers/vfio/pci/vfio_pci_core.c
> > +++ b/drivers/vfio/pci/vfio_pci_core.c
> > @@ -1308,9 +1308,8 @@ static int vfio_pci_ioctl_pci_hot_reset(struct
> vfio_pci_core_device *vdev,
> > }
> >
> > /*
> > - * For each group_fd, get the group through the vfio external user
> > - * interface and store the group and iommu ID. This ensures the group
> > - * is held across the reset.
> > + * Get the group file for each fd to ensure the group held across
> to ensure the group is held

got it.

> Besides
>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>
> Eric
>
>
> > + * the reset
> > */
> > for (file_idx = 0; file_idx < hdr.count; file_idx++) {
> > struct file *file = fget(group_fds[file_idx]);

Regards,
Yi Liu