Re: [kvm-unit-tests PATCH] s390x/snippets: Fix compilation with Clang 15

Nico Boehr
2023-04-04T11:41:02Z

Quoting Thomas Huth (2023-04-04 12:14:34)
> Clang complains:
>
> s390x/snippets/c/cstart.S:22:13: error: invalid operand for instruction
> lghi %r15, stackptr
> ^
> Let's load the address with "larl" instead, like we already do
> it in s390x/cstart64.S. For this we should also switch to 64-bit
> mode first, then we also don't have to clear r15 right in front
> of this anymore.
>
> Changing the code here triggered another problem: initial_cr0
> must be aligned on a double-word boundary, otherwise the lctlg
> instruction will fail with an specification exception. This was
> just working by accident so far - add an ".align 8" now to avoid
> the problem.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Nico Boehr <nrb@linux.ibm.com>