From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14CBC77B61 for ; Fri, 7 Apr 2023 13:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237553AbjDGN5f (ORCPT ); Fri, 7 Apr 2023 09:57:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240447AbjDGN5H (ORCPT ); Fri, 7 Apr 2023 09:57:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55DFCE63 for ; Fri, 7 Apr 2023 06:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680875712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5oB5DxaREwrVRr8+bFg0rReMg3cK5Dvz3xm2hNY4dxU=; b=cerFXZMQmAhgTYf+J2p75VkZ9+iUF3MfZU4k6XjPB7QwME50Azx1/hgYoR5Px2OQHaNbAg Ym+IYAkKlIP3SAbkorLiuD2/Szm6IESpGaMbJSeH79xBzSanTbGwihzJ/ZJxDhB71dU3KX LWXwHY61eqvQq3S1h5TZou+MOHZTtxY= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-_lPDCK9TMEGol2KUiNgPNA-1; Fri, 07 Apr 2023 09:52:00 -0400 X-MC-Unique: _lPDCK9TMEGol2KUiNgPNA-1 Received: by mail-io1-f70.google.com with SMTP id c5-20020a6b4e05000000b007601d480935so6959339iob.10 for ; Fri, 07 Apr 2023 06:52:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680875520; x=1683467520; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5oB5DxaREwrVRr8+bFg0rReMg3cK5Dvz3xm2hNY4dxU=; b=YaLeDIL81OsMft+uDyULRZIR0ylXo72zlsCM53k1u9qMHK8oPj9CXwfWhJtv4ep64P UY4XsjKG6QjReG8etUhkkgbgXJi86ljeHeZjvaicE8ecf679Pax7lztAbZgb4Fo6mGfU t4lDxQNFGtBZsl/+oF3+cxMr+jW6nI2ygN58VmVabITTpG4bIS80ov90LTHs7Q51k4DN LJEGCXq4jYfbfAcEk6bkdZWuSLxoOwStyoMJkCNcBAcReExrmL887P41mGIKiVoXc43w +s5kq1fe1isQKmpLMzPDroY+HJlxtGQeQQarOJcrovcNSd6fMS+7kHtaw/thxixXDrK9 6XSg== X-Gm-Message-State: AAQBX9dbkJfXbqU+2iU4Pd0UQyqlgM7CDoS/3F5pWQf7wGNFIgMHf0yf Oj5N+RHlAiT1ZoOG2kJy2vYCyigy9GTRIX+uHjGmiM3/dqxOWBIghnmGUJOW7CQNNB6tFFGDAXe u4aIEVzqguf7k0O0fU5dPMQ== X-Received: by 2002:a92:d48f:0:b0:328:6172:a743 with SMTP id p15-20020a92d48f000000b003286172a743mr443843ilg.17.1680875519894; Fri, 07 Apr 2023 06:51:59 -0700 (PDT) X-Google-Smtp-Source: AKy350Zt5SmVHCjY2WY3fhBLjS2FZtxV74Lk/zdXvq7uKSlH13byRx8CMKnoBIxJ5VwJKvWvSSSNGA== X-Received: by 2002:a92:d48f:0:b0:328:6172:a743 with SMTP id p15-20020a92d48f000000b003286172a743mr443824ilg.17.1680875519642; Fri, 07 Apr 2023 06:51:59 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id s28-20020a02b15c000000b00374fa5b600csm1112214jah.0.2023.04.07.06.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 06:51:59 -0700 (PDT) Date: Fri, 7 Apr 2023 07:51:55 -0600 From: Alex Williamson To: "Liu, Yi L" Cc: "jgg@nvidia.com" , "Tian, Kevin" , "joro@8bytes.org" , "robin.murphy@arm.com" , "cohuck@redhat.com" , "eric.auger@redhat.com" , "nicolinc@nvidia.com" , "kvm@vger.kernel.org" , "mjrosato@linux.ibm.com" , "chao.p.peng@linux.intel.com" , "yi.y.sun@linux.intel.com" , "peterx@redhat.com" , "jasowang@redhat.com" , "shameerali.kolothum.thodi@huawei.com" , "lulu@redhat.com" , "suravee.suthikulpanit@amd.com" , "intel-gvt-dev@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-s390@vger.kernel.org" , "Hao, Xudong" , "Zhao, Yan Y" , "Xu, Terrence" , "Jiang, Yanting" Subject: Re: [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO Message-ID: <20230407075155.3ad4c804.alex.williamson@redhat.com> In-Reply-To: References: <20230401144429.88673-1-yi.l.liu@intel.com> <20230401144429.88673-13-yi.l.liu@intel.com> <20230403090151.4cb2158c.alex.williamson@redhat.com> <20230407060335.7babfeb8.alex.williamson@redhat.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Fri, 7 Apr 2023 13:24:25 +0000 "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 7, 2023 8:04 PM > > > > > > > > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev, void > > > > *data) > > > > > > if (!iommu_group) > > > > > > return -EPERM; /* Cannot reset non-isolated devices */ > > [1] > > > > > > > > > > > Hi Alex, > > > > > > > > > > Is disabling iommu a sane way to test vfio noiommu mode? > > > > > > > > Yes > > > > > > > > > I added intel_iommu=off to disable intel iommu and bind a device to vfio-pci. > > > > > I can see the /dev/vfio/noiommu-0 and /dev/vfio/devices/noiommu-vfio0. Bind > > > > > iommufd==-1 can succeed, but failed to get hot reset info due to the above > > > > > group check. Reason is that this happens to have some affected devices, and > > > > > these devices have no valid iommu_group (because they are not bound to vfio- > > pci > > > > > hence nobody allocates noiommu group for them). So when hot reset info loops > > > > > such devices, it failed with -EPERM. Is this expected? > > > > > > > > Hmm, I didn't recall that we put in such a limitation, but given the > > > > minimally intrusive approach to no-iommu and the fact that we never > > > > defined an invalid group ID to return to the user, it makes sense that > > > > we just blocked the ioctl for no-iommu use. I guess we can do the same > > > > for no-iommu cdev. > > > > > > I just realize a further issue related to this limitation. Remember that we > > > may finally compile out the vfio group infrastructure in the future. Say I > > > want to test noiommu, I may boot such a kernel with iommu disabled. I think > > > the _INFO ioctl would fail as there is no iommu_group. Does it mean we will > > > not support hot reset for noiommu in future if vfio group infrastructure is > > > compiled out? > > > > We're talking about IOMMU groups, IOMMU groups are always present > > regardless of whether we expose a vfio group interface to userspace. > > Remember, we create IOMMU groups even in the no-iommu case. Even with > > pure cdev, there are underlying IOMMU groups that maintain the DMA > > ownership. > > hmmm. As [1], when iommu is disabled, there will be no iommu_group for a > given device unless it is registered to VFIO, which a fake group is created. > That's why I hit the limitation [1]. When vfio_group is compiled out, then > even fake group goes away. In the vfio group case, [1] can be hit with no-iommu only when there are affected devices which are not bound to vfio. Why are we not allocating an IOMMU group to no-iommu devices when vfio group is disabled? Thanks, Alex