Re: [PATCH 24/33] m68k: Convert various functions to use ptdescs

kernel test robot
2023-04-17T22:19:32Z

Hi Vishal,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on next-20230417]
[cannot apply to s390/features powerpc/next powerpc/fixes geert-m68k/for-next geert-m68k/for-linus linus/master v6.3-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Vishal-Moola-Oracle/s390-Use-_pt_s390_gaddr-for-gmap-address-tracking/20230418-045832
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230417205048.15870-25-vishal.moola%40gmail.com
patch subject: [PATCH 24/33] m68k: Convert various functions to use ptdescs
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230418/202304180652.LeoLmaNQ-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/630b38053b213e6138d3deb3e4325b24ad6dcb1f
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Vishal-Moola-Oracle/s390-Use-_pt_s390_gaddr-for-gmap-address-tracking/20230418-045832
git checkout 630b38053b213e6138d3deb3e4325b24ad6dcb1f
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash arch/m68k/mm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304180652.LeoLmaNQ-lkp@intel.com/

All warnings (new ones prefixed by >>):

arch/m68k/mm/motorola.c: In function 'free_pointer_table':
>> arch/m68k/mm/motorola.c:204:56: warning: passing argument 1 of 'virt_to_ptdesc' makes pointer from integer without a cast [-Wint-conversion]
204 | ptdesc_pte_dtor(virt_to_ptdesc(page));
| ^~~~
| |
| long unsigned int
In file included from arch/m68k/mm/motorola.c:15:
include/linux/mm.h:2721:57: note: expected 'const void *' but argument is of type 'long unsigned int'
2721 | static inline struct ptdesc *virt_to_ptdesc(const void *x)
| ~~~~~~~~~~~~^
arch/m68k/mm/motorola.c: At top level:
arch/m68k/mm/motorola.c:418:13: warning: no previous prototype for 'paging_init' [-Wmissing-prototypes]
418 | void __init paging_init(void)
| ^~~~~~~~~~~

vim +/virt_to_ptdesc +204 arch/m68k/mm/motorola.c

185
186 int free_pointer_table(void *table, int type)
187 {
188 ptable_desc *dp;
189 unsigned long ptable = (unsigned long)table;
190 unsigned long page = ptable & PAGE_MASK;
191 unsigned int mask = 1U << ((ptable - page)/ptable_size(type));
192
193 dp = PD_PTABLE(page);
194 if (PD_MARKBITS (dp) & mask)
195 panic ("table already free!");
196
197 PD_MARKBITS (dp) |= mask;
198
199 if (PD_MARKBITS(dp) == ptable_mask(type)) {
200 /* all tables in page are free, free page */
201 list_del(dp);
202 mmu_page_dtor((void *)page);
203 if (type == TABLE_PTE)
> 204 ptdesc_pte_dtor(virt_to_ptdesc(page));
205 free_page (page);
206 return 1;
207 } else if (ptable_list[type].next != dp) {
208 /*
209 * move this descriptor to the front of the list, since
210 * it has one or more free tables.
211 */
212 list_move(dp, &ptable_list[type]);
213 }
214 return 0;
215 }
216

--
0-DAY CI Kernel Test Service