From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA56AC77B73 for ; Thu, 27 Apr 2023 18:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244536AbjD0SgB (ORCPT ); Thu, 27 Apr 2023 14:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244457AbjD0Sf7 (ORCPT ); Thu, 27 Apr 2023 14:35:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A88FE2 for ; Thu, 27 Apr 2023 11:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682620512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hyhutbl1P5p00Ldo4kjlPS0faKiyka/h141Hh06aCdE=; b=M25jcg0dQh4SA/RgkpFHetKWCgB26mS5bQJCatuRRnk5W3v8uUSCERA4gZI0QhYIQjR+za JEA4LEhnw2Q1xaWRz22QjUJzTxZmUpJyUydBu2WC083Y/+J4E7rdD13gcyto+L2IXcAhHL IxwlPt1+XyFoibZ1zdC7ZowFOhOewQ8= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-dRA_r8uzPPek5gX9THDXNg-1; Thu, 27 Apr 2023 14:35:10 -0400 X-MC-Unique: dRA_r8uzPPek5gX9THDXNg-1 Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-3294f07346aso63721465ab.0 for ; Thu, 27 Apr 2023 11:35:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682620510; x=1685212510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hyhutbl1P5p00Ldo4kjlPS0faKiyka/h141Hh06aCdE=; b=aCk3UnkKxv5Uqi9q13sXXEBdgMbUpgjTN78avQCEgBk1H6E9mu01l2QI40i2ur2ALz VZlZFcrOa6ERLTRG80oaIZHhP7wnZitPxHVCuAUEzkxT4pbR+myLXwcPj9QARMSFpmgp stkdyaKuDjarScRHDdcddHM2YIQ8X9lWCRuIQM8yFvEzYJ7ym4nhcdi09GJ/wkYOkZi5 38x2hbOLiQRcbYVvfztGJZHS/vmv8aB6F/xF1K7ppw8qTabSie6WuwIh/e8usOpKCDuj oi2owMOD9+KSZtJIFT9F1mlPwCIVtZ404o447dpNmYlU7cBvumvHpl08yMGMYTb7sy// s47g== X-Gm-Message-State: AC+VfDyRja4HRXQjNz3YYAbpSzhzqUIDZbtlUdr8XoByVtDo9IRA+bXJ KfB8bQiZDzR2hSPI6kJSSh/P/z33/4dqXt0QTcxt13YuqIlhSiJUP9qQ4TMTHw6jqqKxVHTmNE+ 77Nz434xNKisNWM6aDfLiGQ== X-Received: by 2002:a92:d6c9:0:b0:32a:8a24:31a0 with SMTP id z9-20020a92d6c9000000b0032a8a2431a0mr1740519ilp.31.1682620510012; Thu, 27 Apr 2023 11:35:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qadVzYEMD+1W0+SRpJ/1qXTVhSN/ckiE2OD13eLxYiv9ISmKYP7X6A6gsdcovc2mbQDrEfA== X-Received: by 2002:a92:d6c9:0:b0:32a:8a24:31a0 with SMTP id z9-20020a92d6c9000000b0032a8a2431a0mr1740495ilp.31.1682620509736; Thu, 27 Apr 2023 11:35:09 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id p26-20020a02b01a000000b0040f94ea2a2bsm5647408jah.40.2023.04.27.11.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 11:35:09 -0700 (PDT) Date: Thu, 27 Apr 2023 12:35:08 -0600 From: Alex Williamson To: "Liu, Yi L" Cc: "Tian, Kevin" , "jgg@nvidia.com" , "joro@8bytes.org" , "robin.murphy@arm.com" , "cohuck@redhat.com" , "eric.auger@redhat.com" , "nicolinc@nvidia.com" , "kvm@vger.kernel.org" , "mjrosato@linux.ibm.com" , "chao.p.peng@linux.intel.com" , "yi.y.sun@linux.intel.com" , "peterx@redhat.com" , "jasowang@redhat.com" , "shameerali.kolothum.thodi@huawei.com" , "lulu@redhat.com" , "suravee.suthikulpanit@amd.com" , "intel-gvt-dev@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-s390@vger.kernel.org" , "Hao, Xudong" , "Zhao, Yan Y" , "Xu, Terrence" , "Jiang, Yanting" , "Duan, Zhenzhong" Subject: Re: [PATCH v4 1/9] vfio: Determine noiommu in vfio_device registration Message-ID: <20230427123508.251617d4.alex.williamson@redhat.com> In-Reply-To: References: <20230426145419.450922-1-yi.l.liu@intel.com> <20230426145419.450922-2-yi.l.liu@intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Thu, 27 Apr 2023 07:05:37 +0000 "Liu, Yi L" wrote: > > From: Tian, Kevin > > Sent: Thursday, April 27, 2023 2:36 PM > > > > > From: Liu, Yi L > > > Sent: Wednesday, April 26, 2023 10:54 PM > > > > > > -static inline bool vfio_device_is_noiommu(struct vfio_device *vdev) > > > +static inline int vfio_device_set_noiommu(struct vfio_device *device) > > > { > > > - return IS_ENABLED(CONFIG_VFIO_NOIOMMU) && > > > - vdev->group->type == VFIO_NO_IOMMU; > > > + device->noiommu = IS_ENABLED(CONFIG_VFIO_NOIOMMU) && > > > + device->group->type == VFIO_NO_IOMMU; > > > + return 0; > > > > Just void. this can't fail. > > Hmmm. Yes, before below commit, it cannot fail. Maybe this can be > converted to int later. > > https://lore.kernel.org/kvm/20230426150321.454465-22-yi.l.liu@intel.com/T/#u AFAICT with the comments on the next patch, this change is not at all justified within this series and should be dropped. Thanks, Alex