From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E27C77B7D for ; Thu, 18 May 2023 19:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230273AbjERTvZ (ORCPT ); Thu, 18 May 2023 15:51:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbjERTvX (ORCPT ); Thu, 18 May 2023 15:51:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B7E610C2 for ; Thu, 18 May 2023 12:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684439434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jh5OmsoiniNzfPxTh2q8i8zD0yrfR3xzpW1VvlO4Lwg=; b=HrTxNmgHVIWW4hqCvm1IlTjND79sa4xFdnzTVyMo5leW9UxqV1nYvSjg2ur0SWz4LFQ4zm n6GNBHwMOfZJBQDNiFypk6aVDHfNKJYkDjyiZmKONOuVxNs819jm7N7UbcT9gQjo8Fowxh Vf6WQSDk/duKTtazmU2YDijIMv6nhOc= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-XrjgLV4nN4-zaVfD93Ddow-1; Thu, 18 May 2023 15:50:33 -0400 X-MC-Unique: XrjgLV4nN4-zaVfD93Ddow-1 Received: by mail-il1-f200.google.com with SMTP id e9e14a558f8ab-338615fc4efso484335ab.1 for ; Thu, 18 May 2023 12:50:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684439432; x=1687031432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jh5OmsoiniNzfPxTh2q8i8zD0yrfR3xzpW1VvlO4Lwg=; b=NBXWyQhvddfZgZgmvpjvcQla77sZ8Y/0egD541rGzrIws+IpY+03teKHmQtj7LxJdk alqOhxIOGwmN/XfBgbi0YGBq3u7kwOn/SHNxyzZRTuVqF2DnuhNFY0jIhOmFmWKJzgyk dLv0eYicfZmsoM6ZLYZexzMLHKPLpWgKjgCk/FEhQUQtPxkEkLFxWHQgbrekQlhwgfD2 st4wfnNfzoBf/MbjOsA0xalGfibk+4TDMhBUwyHZkKl4fP/CXThSa2tLD3bCm8mUkKiD 9MJH5OzYF6W0t4NafjadQgQuBKXBdp8L4zd0KfgR6pDT6R+2XrNoffyXbyIZQRKgTENt cAgg== X-Gm-Message-State: AC+VfDypx/tUXlmyJwMAc3WVcksg96XT6ft50ti9nCHNNzOc32cVXLgX dfRhO52eEKRRii1bfku3kC/Mc+6T62pFLWJErE+Ps/oxCumUV/7JnRV9g8j7o9fubntBhWEzmQD ZxO7Q4EpqDxrmwbJ0HRLc9A== X-Received: by 2002:a05:6e02:1aa3:b0:333:49f9:a5f3 with SMTP id l3-20020a056e021aa300b0033349f9a5f3mr4588890ilv.2.1684439432075; Thu, 18 May 2023 12:50:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5FxhxTBMgm7TCu3seuae29eNjQqi+QvYLiW+iwyYL0QmMjButMon7ajVdlh0YbG0jeo2m46g== X-Received: by 2002:a05:6e02:1aa3:b0:333:49f9:a5f3 with SMTP id l3-20020a056e021aa300b0033349f9a5f3mr4588864ilv.2.1684439431737; Thu, 18 May 2023 12:50:31 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id f16-20020a02cad0000000b0041643b78cbesm664248jap.120.2023.05.18.12.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 12:50:31 -0700 (PDT) Date: Thu, 18 May 2023 13:50:29 -0600 From: Alex Williamson To: "Liu, Yi L" Cc: "jgg@nvidia.com" , "Tian, Kevin" , "joro@8bytes.org" , "robin.murphy@arm.com" , "cohuck@redhat.com" , "eric.auger@redhat.com" , "nicolinc@nvidia.com" , "kvm@vger.kernel.org" , "mjrosato@linux.ibm.com" , "chao.p.peng@linux.intel.com" , "yi.y.sun@linux.intel.com" , "peterx@redhat.com" , "jasowang@redhat.com" , "shameerali.kolothum.thodi@huawei.com" , "lulu@redhat.com" , "suravee.suthikulpanit@amd.com" , "intel-gvt-dev@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-s390@vger.kernel.org" , "Hao, Xudong" , "Zhao, Yan Y" , "Xu, Terrence" , "Jiang, Yanting" , "Duan, Zhenzhong" , "clegoate@redhat.com" Subject: Re: [PATCH v5 06/10] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device Message-ID: <20230518135029.26abe519.alex.williamson@redhat.com> In-Reply-To: References: <20230513132136.15021-1-yi.l.liu@intel.com> <20230513132136.15021-7-yi.l.liu@intel.com> <20230517121517.4b7ceb52.alex.williamson@redhat.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Thu, 18 May 2023 13:25:59 +0000 "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 2:15 AM > > > > On Sat, 13 May 2023 06:21:32 -0700 > > Yi Liu wrote: > > > > > This is needed by the vfio-pci driver to report affected devices in the > > > hot reset for a given device. > > > > > > Signed-off-by: Yi Liu > > > --- > > > drivers/iommu/iommufd/device.c | 24 ++++++++++++++++++++++++ > > > drivers/vfio/iommufd.c | 20 ++++++++++++++++++++ > > > include/linux/iommufd.h | 6 ++++++ > > > include/linux/vfio.h | 14 ++++++++++++++ > > > 4 files changed, 64 insertions(+) > > > > > > diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c > > > index 4f9b2142274c..81466b97023f 100644 > > > --- a/drivers/iommu/iommufd/device.c > > > +++ b/drivers/iommu/iommufd/device.c > > > @@ -116,6 +116,18 @@ void iommufd_device_unbind(struct iommufd_device *idev) > > > } > > > EXPORT_SYMBOL_NS_GPL(iommufd_device_unbind, IOMMUFD); > > > > > > +struct iommufd_ctx *iommufd_device_to_ictx(struct iommufd_device *idev) > > > +{ > > > + return idev->ictx; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_ictx, IOMMUFD); > > > + > > > +u32 iommufd_device_to_id(struct iommufd_device *idev) > > > +{ > > > + return idev->obj.id; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_id, IOMMUFD); > > > + > > > static int iommufd_device_setup_msi(struct iommufd_device *idev, > > > struct iommufd_hw_pagetable *hwpt, > > > phys_addr_t sw_msi_start) > > > @@ -463,6 +475,18 @@ void iommufd_access_destroy(struct iommufd_access > > *access) > > > } > > > EXPORT_SYMBOL_NS_GPL(iommufd_access_destroy, IOMMUFD); > > > > > > +struct iommufd_ctx *iommufd_access_to_ictx(struct iommufd_access *access) > > > +{ > > > + return access->ictx; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_ictx, IOMMUFD); > > > + > > > +u32 iommufd_access_to_id(struct iommufd_access *access) > > > +{ > > > + return access->obj.id; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_id, IOMMUFD); > > > + > > > int iommufd_access_attach(struct iommufd_access *access, u32 ioas_id) > > > { > > > struct iommufd_ioas *new_ioas; > > > diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c > > > index c1379e826052..a18e920be164 100644 > > > --- a/drivers/vfio/iommufd.c > > > +++ b/drivers/vfio/iommufd.c > > > @@ -105,6 +105,26 @@ void vfio_iommufd_unbind(struct vfio_device *vdev) > > > vdev->ops->unbind_iommufd(vdev); > > > } > > > > > > +struct iommufd_ctx *vfio_iommufd_physical_ictx(struct vfio_device *vdev) > > > +{ > > > + if (vdev->iommufd_device) > > > + return iommufd_device_to_ictx(vdev->iommufd_device); > > > + if (vdev->noiommu_access) > > > + return iommufd_access_to_ictx(vdev->noiommu_access); > > > + return NULL; > > > +} > > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_ictx); > > > + > > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > > +{ > > > + if (vdev->iommufd_device) > > > + return iommufd_device_to_id(vdev->iommufd_device); > > > + if (vdev->noiommu_access) > > > + return iommufd_access_to_id(vdev->noiommu_access); > > > + return -EINVAL; > > > +} > > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); > > > > I think these exemplify that it would be better if both emulated and > > noiommu use the same iommufd_access pointer. Thanks, > > Sure. Then I shall rename this helper. vfio_iommufd_device_devid() > What about your opinion? Yes, it really didn't even occur to me that "physical" in the name was meant to suggest this shouldn't be used for emulated mdev devices. It should work for all devices and using a shared iommufd access pointer between noiommu and emulated should simplify that somewhat. Thanks, Alex