Re: [kvm-unit-tests PATCH v3 5/6] s390x: lib: sie: don't reenter SIE on pgm int

Claudio Imbrenda
2023-06-30T15:54:09Z

On Fri, 30 Jun 2023 16:59:06 +0200
Nico Boehr <nrb@linux.ibm.com> wrote:

> [...]
> > > diff --git a/lib/s390x/asm/interrupt.h b/lib/s390x/asm/interrupt.h
> > > index 55759002dce2..fb4283a40a1b 100644
> > > --- a/lib/s390x/asm/interrupt.h
> > > +++ b/lib/s390x/asm/interrupt.h
> > > @@ -99,4 +99,18 @@ static inline void low_prot_disable(void)
> > > ctl_clear_bit(0, CTL0_LOW_ADDR_PROT);
> > > }
> > >
> > > +/**
> > > + * read_pgm_int_code - Get the program interruption code of the last pgm int
> > > + * on the current CPU.
> >
> > All of the other functions are in the c file.
>
> Claudio requested this to be in the C file, I really don't mind much. Claudio,

you meant header

> maybe you can elaborate why you wanted it in the header.

so it can be inlined it's literally just a read... you can put it in
the C file if you want, but it seems a waste to me tbh

>
> > > + *
> > > + * This is similar to clear_pgm_int(), except that it doesn't clear the
> > > + * interruption information from lowcore.
> > > + *
> > > + * Returns 0 when none occured.
> >
> > s/r/rr/
>
> Fixed.
>
> > > + */
> > > +static inline uint16_t read_pgm_int_code(void)
> > > +{
> >
> > No mb()?
>
> This is a function call, so none should be needed, no?