Re: [kvm-unit-tests PATCH v3 1/6] lib: s390x: introduce bitfield for PSW mask

Janosch Frank
2023-06-05T14:23:44Z

On 6/5/23 12:35, Claudio Imbrenda wrote:
> On Thu, 1 Jun 2023 09:42:48 +0200
> Janosch Frank <frankja@linux.ibm.com> wrote:
>
> [...]
>
>> Hrm, since I already made the mistake of introducing bitfields with and
>> without spaces between the ":" I'm in no position to complain here.
>>
>> I'm also not sure what the consensus is.
>
> tbh I don't really have an opinion, I don't mind either, to the point
> that I don't even care if we mix them
>
>>
>>> + };
>>> + };
>>> uint64_t addr;
>>> };
>>
>> I've come to like static asserts for huge structs and bitfields since
>> they can safe you from a *lot* of headaches.
>
> you mean statically asserting that the size is what it should be?
> in that case fully agree
>

Yes, asserting the size.