From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA76AC77B7A for ; Thu, 1 Jun 2023 20:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232235AbjFAUsM (ORCPT ); Thu, 1 Jun 2023 16:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232056AbjFAUsM (ORCPT ); Thu, 1 Jun 2023 16:48:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 068671B1 for ; Thu, 1 Jun 2023 13:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685652446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rmRZRfKWVEY0SEozIOD2eDdbXyNH6CzhN64nvWsaek4=; b=hcoGCZHX/bF7dj/+y+LhNr3cEo7qCC2h1wN64+IkzT1BpWyPosxhb3CSiUjkgz7LLjk7i0 fiDyNlIQP3jmMgcvW1hgl79RdruhK79oR+vNiKC69I6/Kwhc4lRNYLfxpmosOSQE5k+haW OsK5BgKoECZazjNOZgi3ICq7km+hGf4= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-YizP4p7lOw6hM1ArY_AEjQ-1; Thu, 01 Jun 2023 16:47:24 -0400 X-MC-Unique: YizP4p7lOw6hM1ArY_AEjQ-1 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-7775a282e25so31594639f.0 for ; Thu, 01 Jun 2023 13:47:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685652444; x=1688244444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rmRZRfKWVEY0SEozIOD2eDdbXyNH6CzhN64nvWsaek4=; b=FQyZ91HU8i21sM45v/4FzAaid0dJDvZlSMa289KhA3jojbBDr5JqcG8dRmECUpNn21 dj9ajfqCxHffc4tnAb07spMQLZ2V+dFEGgG+SbO3yFa00cCubF7hy8BaTFnOTfN5cNmt GkEbRo2yb5SnypYWpcUgzsnaG2DD4H+eIaC33RoPPGhYGDPzSOWJ0sqbQI94RkkzABfV nXBiGDU4sBV0WDfB2WPI3oaEkcWwouU58dEsx6kRkrIqW57es7v8OIMHgfMpTyugbmwn QcpqegYuK8ySC4SNALaQ+BsqVRvHsX75XUZFOmPNA77aXsmnSv/PSMBWHA1aUWOc6WjJ O81w== X-Gm-Message-State: AC+VfDwRfDKPMV3XoF4ViHadxKEaTGI6v13ENqIQO5Cwzj5lYprLv7Yd syLa5lw8gF6ble86VTMRXSIX7FQpVrv/QOvo1HXQH9PS9oX1rjvzn2GJ6Hss8fECg/V7aNJzkJw MVkdwmEw2jclEEct3iFuLew== X-Received: by 2002:a6b:6314:0:b0:774:982e:cb0a with SMTP id p20-20020a6b6314000000b00774982ecb0amr439736iog.15.1685652443898; Thu, 01 Jun 2023 13:47:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5SzX6PbeMg9q9vvXLKsxsPVcmec31tIfdfceJjEB6+21sbwbfrKA2JAoEEGHsUYkyz/sbdhA== X-Received: by 2002:a6b:6314:0:b0:774:982e:cb0a with SMTP id p20-20020a6b6314000000b00774982ecb0amr439722iog.15.1685652443672; Thu, 01 Jun 2023 13:47:23 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id l23-20020a056638221700b004164fe77c06sm2571841jas.26.2023.06.01.13.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 13:47:23 -0700 (PDT) Date: Thu, 1 Jun 2023 14:47:22 -0600 From: Alex Williamson To: Matthew Rosato Cc: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , Vasily Gorbik , "agordeev@linux.ibm.com" , jjherne@linux.ibm.com, pasic@linux.ibm.com, farman@linux.ibm.com, borntraeger@linux.ibm.com, Cedric Le Goater Subject: Re: [PATCH 0/3] s390/vfio-ap: fix hang when mdev attached to guest is removed Message-ID: <20230601144722.6eba9c49.alex.williamson@redhat.com> In-Reply-To: <30741787-441a-034f-f8d4-9f1060841051@linux.ibm.com> References: <20230530223538.279198-1-akrowiak@linux.ibm.com> <30741787-441a-034f-f8d4-9f1060841051@linux.ibm.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Wed, 31 May 2023 10:51:54 -0400 Matthew Rosato wrote: > On 5/30/23 6:35 PM, Tony Krowiak wrote: > > When a user attempts to remove a vfio-ap mediated device attached to a > > guest, the operation hangs until the mdev's fd is closed by the guest > > (i.e., the hostdev is detached or the guest is shut down). This patch > > series provides kernel-side code that allows userspace to set up a > > communication channel that will allow the vfio_ap device driver to notify > > userspace when a request to release the mdev is received, so that userspace > > can close the mdev fd and avoid the hang. The patch series provides the > > following: > > > > 1. Introduces code to handle the VFIO_DEVICE_GET_IRQ_INFO and > > VFIO_DEVICE_SET_IRQS ioctl calls to set the eventfd_ctx for signaling a > > device request to userspace. > > > > 2. Wires up the VFIO bus driver callback to request a release of the mdev. > > When invoked, the vfio_ap device driver will use the eventfd_ctx set up > > in #1 to signal a request to userspace to release the mdev. > > > > As to how this series eventually reaches master... It touches both s390 and vfio. > > @Alex/@s390 maintainers -- I suggest it go through s390 given the > diffstat, it's almost completely in s390 drivers code. However there > is a uapi hit to vfio.h (in patch 1) that should get at least an ACK > from Alex beforehand. Ack'd, I'll expect this to go through the s390 tree. Thanks, Alex