Re: [PATCH net-next v2 6/6] net/smc: Extend SMCR v2 linkgroup netlink attribute

Jan Karcher
2023-08-18T19:43:28Z

On 17/08/2023 15:20, Guangguan Wang wrote:
> Add SMC_NLA_LGR_R_V2_MAX_CONNS and SMC_NLA_LGR_R_V2_MAX_LINKS
> to SMCR v2 linkgroup netlink attribute SMC_NLA_LGR_R_V2 for
> linkgroup's detail info showing.
>
> Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>

Thank you for your contribution, Guangguan.

Reviewed-by: Jan Karcher <jaka@linux.ibm.com>

> ---
> include/uapi/linux/smc.h | 2 ++
> net/smc/smc_core.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/include/uapi/linux/smc.h b/include/uapi/linux/smc.h
> index bb4dacca31e7..837fcd4b0abc 100644
> --- a/include/uapi/linux/smc.h
> +++ b/include/uapi/linux/smc.h
> @@ -107,6 +107,8 @@ enum {
> enum {
> SMC_NLA_LGR_R_V2_UNSPEC,
> SMC_NLA_LGR_R_V2_DIRECT, /* u8 */
> + SMC_NLA_LGR_R_V2_MAX_CONNS, /* u8 */
> + SMC_NLA_LGR_R_V2_MAX_LINKS, /* u8 */
> __SMC_NLA_LGR_R_V2_MAX,
> SMC_NLA_LGR_R_V2_MAX = __SMC_NLA_LGR_R_V2_MAX - 1
> };
> diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c
> index 1e1475084bb4..ef5336df3b09 100644
> --- a/net/smc/smc_core.c
> +++ b/net/smc/smc_core.c
> @@ -319,6 +319,10 @@ static int smc_nl_fill_smcr_lgr_v2(struct smc_link_group *lgr,
> goto errattr;
> if (nla_put_u8(skb, SMC_NLA_LGR_R_V2_DIRECT, !lgr->uses_gateway))
> goto errv2attr;
> + if (nla_put_u8(skb, SMC_NLA_LGR_R_V2_MAX_CONNS, lgr->max_conns))
> + goto errv2attr;
> + if (nla_put_u8(skb, SMC_NLA_LGR_R_V2_MAX_LINKS, lgr->max_links))
> + goto errv2attr;
>
> nla_nest_end(skb, v2_attrs);
> return 0;