Re: [PATCH 3/4] selinuxfs: free sb->s_fs_info after shutting down the super block

Al Viro
2023-08-31T06:33:59Z

On Thu, Aug 31, 2023 at 07:31:56AM +0200, Christoph Hellwig wrote:
> sb->s_fs_info can only be safely freed after generic_shutdown_super was
> called and all access to the super_block has stopped.
>
> Thus only free the private data after calling kill_litter_super, which
> calls generic_shutdown_super internally.

Same as for ramfs, AFAICS.

> Also remove the duplicate freeing in the sel_fill_super error path given
> that ->kіll_sb is also called on ->fill_super failure.

Reasonable cleanup, that.