Re: [PATCH 3/8] arch/x86: Remove sentinel elem from ctl_table arrays

Joel Granados
2023-09-07T18:26:32Z

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

On Wed, Sep 06, 2023 at 07:45:09AM -0700, Dave Hansen wrote:
> On 9/6/23 03:03, Joel Granados via B4 Relay wrote:
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which
> > will reduce the overall build time size of the kernel and run time
> > memory bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> >
> > Remove sentinel element from sld_sysctl and itmt_kern_table.
>
> There's a *LOT* of content to read for a reviewer to figure out what's
> going on here between all the links. I would have appreciated one more
> sentence here, maybe:
>
> This is now safe because the sysctl registration code
> (register_sysctl()) implicitly uses ARRAY_SIZE() in addition
> to checking for a sentinel.
Thx for the feedback. This is a great sentence to add at the end of the
first paragraph instead of the link. I'll add it with a few changes as
there are more than just one register function and the use of ARRAY_SIZE
is implicit most of the time.

This is now safe because the sysctl registration code
(register_sysctl() and friends) use the array size in addition to
checking for a sentinel.

I have changed my cover letter in case I send a V2 and for the other
batches that are coming after the architecture one.

>
> That needs to be more prominent _somewhere_. Maybe here, or maybe in
> the cover letter, but _somewhere_.
This is also a good point. I think having it in both the cover letter
and each of the commits is an added value.

>
> That said, feel free to add this to the two x86 patches:
>
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com> # for x86

Best

--

Joel Granados

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]