Re: [PATCH linux-next v3 10/14] sh, crash: wrap crash dumping code into crash related ifdefs

John Paul Adrian Glaubitz
2024-01-24T08:13:21Z

Hello Baoquan,

On Wed, 2024-01-24 at 13:12 +0800, Baoquan He wrote:
> Now crash codes under kernel/ folder has been split out from kexec
> code, crash dumping can be separated from kexec reboot in config
> items on SuperH with some adjustments.
>
> wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery, and
> use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compiling
> in the crashkernel reservation code.

Comparing this to the patches, it seems you missed the first word
"Here". Either amend that or write the word "wrap" capitalized.

I would omit "Here" as it's not necessary and just start the
sentence with "Wrap".

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913