Re: [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c

Klara Modin
2024-01-28T01:28:32Z

Hi,

On 2024-01-24 06:12, Baoquan He wrote:
> And also add config item CRASH_RESERVE to control its enabling of the
> codes. And update config items which has relationship with crashkernel
> reservation.
>
> And also change ifdeffery from CONFIG_CRASH_CORE to CONFIG_CRASH_RESERVE
> when those scopes are only crashkernel reservation related.

> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 502986237cb6..a9243e0948a3 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2106,7 +2106,7 @@ config ARCH_SUPPORTS_CRASH_HOTPLUG
> def_bool y
>
> config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> - def_bool CRASH_CORE
> + def_bool CRASH_RESEERVE
>
> config PHYSICAL_START
> hex "Physical address where the kernel is loaded" if (EXPERT || CRASH_DUMP)

CRASH_RESEERVE is probably a typo and should be CRASH_RESERVE (with the
former ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION isn't defined in my
.config and `crashkernel=...` parameter has no effect).

Kind regards,
Klara Modin