Re: [PATCH v13 05/21] KVM: pfncache: remove KVM_GUEST_USES_PFN usage

Paul Durrant
2024-02-20T09:00:20Z

On 19/02/2024 21:43, Sean Christopherson wrote:
> On Thu, Feb 15, 2024, Paul Durrant wrote:
>> From: Paul Durrant <pdurrant@amazon.com>
>>
>> As noted in [1] the KVM_GUEST_USES_PFN usage flag is never set by any
>> callers of kvm_gpc_init(), which also makes the 'vcpu' argument redundant.
>
> The changelog should explicitly call out that not only is KVM_GUEST_USES_PFN
> unused, it's incomplete/broken (which is also partly why it's unused). Without
> that information, removing the support looks like a somewhat arbitrary decision,
> versus a deliberate change to make it easier to support the gpc code.

Ok. I'll add some words to that effect.