Re: [kvm-unit-tests RFC PATCH 02/17] shellcheck: Fix SC2223

Andrew Jones
2024-04-05T14:14:40Z

On Fri, Apr 05, 2024 at 07:00:34PM +1000, Nicholas Piggin wrote:
> SC2223 (info): This default assignment may cause DoS due to globbing.
> Quote it.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> run_tests.sh | 4 ++--
> scripts/runtime.bash | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/run_tests.sh b/run_tests.sh
> index bb3024ff9..9067e529e 100755
> --- a/run_tests.sh
> +++ b/run_tests.sh
> @@ -158,8 +158,8 @@ function run_task()
> fi
> }
>
> -: ${unittest_log_dir:=logs}
> -: ${unittest_run_queues:=1}
> +: "${unittest_log_dir:=logs}"
> +: "${unittest_run_queues:=1}"
> config=$TEST_DIR/unittests.cfg
>
> print_testname()
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index e4ad1962f..2d7ff5baa 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -1,6 +1,6 @@
> : "${RUNTIME_arch_run?}"
> -: ${MAX_SMP:=$(getconf _NPROCESSORS_ONLN)}
> -: ${TIMEOUT:=90s}
> +: "${MAX_SMP:=$(getconf _NPROCESSORS_ONLN)}"
> +: "${TIMEOUT:=90s}"
>
> PASS() { echo -ne "\e[32mPASS\e[0m"; }
> SKIP() { echo -ne "\e[33mSKIP\e[0m"; }
> --
> 2.43.0

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>