From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A642516F296 for ; Fri, 5 Apr 2024 14:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712328161; cv=none; b=USxHEr7PCITGbj+Ic8C+KDYTGm8uQF7ts9xk6HZ92fkg0DANKJ7k4c0du4ssW/owNeegKVJIupU03zG3HqYpV7X/1qWOf6TUTFmFBXyGyNi9R70MdXTGuu5HQ5lhfFIhtMVy92ZUiP7Ob/rV8ATe2U+By4PPOtoVTTuoEFWHYms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712328161; c=relaxed/simple; bh=IBgLqZ3buoW3IdRadEfg19LCfS2zlDBoNVByQfz6mhc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SPX6Hq88+mbslP50sWTRZZLl0ei4HCDm5Eo6o/3wdefOzhe8ZGd7a6JgbimMO61EHuG7sYAa1UIHFTd9+PAXvDYZv+nQDQIl/FwrJP030so7rU8vVElM1cpmG0C5K87dCGEtNlmU0yf+cLHZAmW1h0Ir/WA+PJSOIwlxU/i3ZQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gJEPi+8c; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gJEPi+8c" Date: Fri, 5 Apr 2024 16:42:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712328157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MtcQADxBXA1YhPpuZ7fmH3qMlXh/3dMUEIRBQ9SwmCw=; b=gJEPi+8cQKLjU7x3MMQHoNFtaKwz61gNAoQCnLPgjgrRqvnNyCapGWfbD4SlPswFdBxkOD sdmzbXkHO1tZ2+56b1t5cpLOcKoKIsuEJTs5uaNS31QkFWn9MTzM5x4rb64Gjc8GBjPfP5 Qie3NDNKWKaC8D2zo5PfCQVSghaXbDY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nicholas Piggin Cc: Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , Nico =?utf-8?B?QsO2aHI=?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , Nadav Amit , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests RFC PATCH 16/17] shellcheck: Fix SC2153 Message-ID: <20240405-8c07ba91470a6bb355c3fdba@orel> References: <20240405090052.375599-1-npiggin@gmail.com> <20240405090052.375599-17-npiggin@gmail.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405090052.375599-17-npiggin@gmail.com> X-Migadu-Flow: FLOW_OUT On Fri, Apr 05, 2024 at 07:00:48PM +1000, Nicholas Piggin wrote: > SC2153 (info): Possible misspelling: ACCEL may not be assigned. Did > you mean accel? > > Looks like a bug? Agreed. > > Signed-off-by: Nicholas Piggin > --- > scripts/s390x/func.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash > index 6c75e89ae..fa47d0191 100644 > --- a/scripts/s390x/func.bash > +++ b/scripts/s390x/func.bash > @@ -21,7 +21,7 @@ function arch_cmd_s390x() > "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > > # run PV test case > - if [ "$ACCEL" = 'tcg' ] || grep -q "migration" <<< "$groups"; then > + if [ "$accel" = 'tcg' ] || grep -q "migration" <<< "$groups"; then > return > fi > kernel=${kernel%.elf}.pv.bin > -- > 2.43.0 > Reviewed-by: Andrew Jones