From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AAB816F0EC for ; Fri, 5 Apr 2024 14:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326669; cv=none; b=DeNsGWMCNIlNF7gDkHqQuCTaEwgWY5Iy7w12vML6mySasmFA/w9hw6oxZXR0cyzq3AthXcpudc76rOnNQskxqK2KoKLJyHLyejtZKQ+piw2PE6L3qPRbpYaXPjtdyokyBtWwDNHQrQ1osm9hNMx04PlakN/fzWZxB7myvodkJbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326669; c=relaxed/simple; bh=R0ZLdJVsrBk5k+x8D8om4leWpCwPagPZ43a3wzPFQHg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V/+elnVMhPDHLhJhqHoC/gca34VmXk0dTkAzJcCgbZ1MrR14DdSD3BVAY1QVlk3zifXZCo6tclBpQNzhIYIJq8bWAK3YPKfXy11+GMYgwGdKEzyBdNUW4sa6npJfMtwLr+s7a5LAGMChosP/N7eJ84vgGHm9zMJr6IkPu5B+oEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Tl+dsqvx; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Tl+dsqvx" Date: Fri, 5 Apr 2024 16:17:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712326664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZFNTgutA3vHipkSVU5HxpHR61gsE+oNdmE4mMKLzbMc=; b=Tl+dsqvxUCdF5XqzJyjj2P56JJGhBus3B04s9Cdo2RsF+X2FQEXxXlPBflwAaBEufxvf+j yhg1dy2uY6Vt0T20qr6jHr7zHsqvkOv1gMAUOsHI8Cu3sB5yd9NDXTBfobrS9w6pQJbwk/ ynz14ElXGrkREqOGEc0csEYlKR/WsKU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nicholas Piggin Cc: Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , Nico =?utf-8?B?QsO2aHI=?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , Nadav Amit , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests RFC PATCH 05/17] shellcheck: Fix SC2006 Message-ID: <20240405-f5a043bb8fa1230ca636f62e@orel> References: <20240405090052.375599-1-npiggin@gmail.com> <20240405090052.375599-6-npiggin@gmail.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405090052.375599-6-npiggin@gmail.com> X-Migadu-Flow: FLOW_OUT On Fri, Apr 05, 2024 at 07:00:37PM +1000, Nicholas Piggin wrote: > SC2006 (style): Use $(...) notation instead of legacy backticks `...`. > > No bug identified. > > Signed-off-by: Nicholas Piggin > --- > scripts/arch-run.bash | 6 +++--- > scripts/runtime.bash | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 472c31b08..f9d1fade9 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -271,16 +271,16 @@ do_migration () > qmp ${src_qmp} '"migrate", "arguments": { "uri": "unix:'${dst_incoming}'" }' > ${src_qmpout} > > # Wait for the migration to complete > - migstatus=`qmp ${src_qmp} '"query-migrate"' | grep return` > + migstatus=$(qmp ${src_qmp} '"query-migrate"' | grep return) > while ! grep -q '"completed"' <<<"$migstatus" ; do > sleep 0.1 > - if ! migstatus=`qmp ${src_qmp} '"query-migrate"'`; then > + if ! migstatus=$(qmp ${src_qmp} '"query-migrate"'); then > echo "ERROR: Querying migration state failed." >&2 > echo > ${dst_infifo} > qmp ${dst_qmp} '"quit"'> ${dst_qmpout} 2>/dev/null > return 2 > fi > - migstatus=`grep return <<<"$migstatus"` > + migstatus=$(grep return <<<"$migstatus") > if grep -q '"failed"' <<<"$migstatus"; then > echo "ERROR: Migration failed." >&2 > echo > ${dst_infifo} > diff --git a/scripts/runtime.bash b/scripts/runtime.bash > index 2d7ff5baa..f79c4e281 100644 > --- a/scripts/runtime.bash > +++ b/scripts/runtime.bash > @@ -61,9 +61,9 @@ function print_result() > local reason="$4" > > if [ -z "$reason" ]; then > - echo "`$status` $testname $summary" > + echo "$($status) $testname $summary" > else > - echo "`$status` $testname ($reason)" > + echo "$($status) $testname ($reason)" > fi > } > > -- > 2.43.0 > Reviewed-by: Andrew Jones