Re: [kvm-unit-tests RFC PATCH 15/17] shellcheck: Fix SC2048

Andrew Jones
2024-04-05T14:40:49Z

On Fri, Apr 05, 2024 at 07:00:47PM +1000, Nicholas Piggin wrote:
> SC2048 (warning): Use "$@" (with quotes) to prevent whitespace
> problems.
>
> Not sure if there's a real bug.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> run_tests.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/run_tests.sh b/run_tests.sh
> index 116188e92..938bb8edf 100755
> --- a/run_tests.sh
> +++ b/run_tests.sh
> @@ -44,7 +44,7 @@ fi
>
> only_tests=""
> list_tests=""
> -args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list,probe-maxsmp -- $*)
> +args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list,probe-maxsmp -- "$@")
> [ $? -ne 0 ] && exit 2;
> set -- $args;
> while [ $# -gt 0 ]; do
> --
> 2.43.0
>

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>