Re: [kvm-unit-tests RFC PATCH 10/17] shellcheck: Fix SC2013

Andrew Jones
2024-04-05T14:31:40Z

On Fri, Apr 05, 2024 at 07:00:42PM +1000, Nicholas Piggin wrote:
> SC2013 (info): To read lines rather than words, pipe/redirect to a
> 'while read' loop.
>
> Not a bug.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> scripts/arch-run.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
> index 9dc34a54a..e5750cb98 100644
> --- a/scripts/arch-run.bash
> +++ b/scripts/arch-run.bash
> @@ -487,7 +487,7 @@ env_file ()
>
> [ ! -f "$KVM_UNIT_TESTS_ENV_OLD" ] && return
>
> - for line in $(grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD"); do
> + grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD" | while IFS= read -r line ; do
> var=${line%%=*}
> if ! grep -q "^$var=" $KVM_UNIT_TESTS_ENV; then
> eval export "$line"
> --
> 2.43.0
>

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>