From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4632BAE1 for ; Mon, 8 Apr 2024 07:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712561685; cv=none; b=JU1bO25NUOpWNmx3CQUf+1HZKjyfqq/yd+kmADfPaY3WU1YXYk/UC8ECXzltmV4mj+ZELiZTIPLP3UMxbTw+9df3kNpJCIN04nvIUreu5g6fa0fVf2rNU26CKheBZOxK7xNzXT2qH3OQSzjg7ZnUdfqQ5Oas6fHDPGRyl1GA5t8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712561685; c=relaxed/simple; bh=mMUwQsISZ3FCjJWcZ6UWs3mYihezqlyVRuD1ROQxLmw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JhT3mdU7QFGL6y8TkYlY24CdDUz3CAa4MCs6MwatJGmYOoyxWqIQQ93TZCFdVyFko9pc1KxP2DLSGPyMieuIBUNDD6c/3dqVxyQSndDtC0+TAk871uSKh3StN/j/4ME1Fwz7dVHhyzUHY6AUY5rSvreJbj1MHzQo3vKTnWj1vp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QW2M3V5X; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QW2M3V5X" Date: Mon, 8 Apr 2024 09:34:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712561680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5jsUX7EP8Oi6cHnp1CX3FRa9IfBRQ/u9Wx/VAw8PMro=; b=QW2M3V5Xg44hm96pJLD+mUcAJHfhL35bCtMvGSe++4MaQ7ullSJE7KpKl6vu7EydQpP8c0 Z4Yds0Vk11wQ2cJTNUPG5XqKbk9NpUGLXIOFpfEQ63rtaeo6w9oKPBELd6pIz/bJgu3Jiz uAsuDnse0XrrZrH0JmzoztkyzNe56qw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nicholas Piggin Cc: Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , Nico =?utf-8?B?QsO2aHI=?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [RFC kvm-unit-tests PATCH v2 08/14] shellcheck: Fix SC2013 Message-ID: <20240408-840ece34e7b407365a18227d@orel> References: <20240406123833.406488-1-npiggin@gmail.com> <20240406123833.406488-9-npiggin@gmail.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240406123833.406488-9-npiggin@gmail.com> X-Migadu-Flow: FLOW_OUT On Sat, Apr 06, 2024 at 10:38:17PM +1000, Nicholas Piggin wrote: > SC2013 (info): To read lines rather than words, pipe/redirect to a > 'while read' loop. > > Not a bug. > > Signed-off-by: Nicholas Piggin > --- > scripts/arch-run.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index cd75405c8..45ec8f57d 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -487,7 +487,7 @@ env_file () > > [ ! -f "$KVM_UNIT_TESTS_ENV_OLD" ] && return > > - for line in $(grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD"); do > + grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD" | while IFS= read -r line ; do > var=${line%%=*} > if ! grep -q "^$var=" $KVM_UNIT_TESTS_ENV; then > eval export "$line" > -- > 2.43.0 > I already gave an r-b on this one. Here it is again, Reviewed-by: Andrew Jones