From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CB691292CE; Tue, 16 Apr 2024 11:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713267751; cv=none; b=K4krhzZ8CKWeCB3deMS3Oc7b+Dsrvs+fK684Rg6ECO+r02Lhkp+46qid1w7GaQq7aT3XweqFEGGnURlYg9Jz+f3awIAbTS4eV9rTJNLrHJf+nbAx1arhrtuRQQU920UajrPRXxjpsBUmOipmBAfxFoHlf7W2x7qtBZ8JpHpcADQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713267751; c=relaxed/simple; bh=ff4QEueDlvLGXin5kN+Z8EllcRCaeL9diJClGL5sqmk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pnKQ3rg4KqOjxrRftSrBr1oMZrol1K/V5W/UGevBjzexYewV7VTfLJwFiwbpop3gH13iBYMnapBG/bq6ColCAmeCg/kh3REXhQIcWNLNYLRR/oix3c0Z6KGxCBcficlNJS3Er+eGHoPiJ/vGdHIiY5fQrgkdqeLuisQV16VCr7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=bqq2tLI5; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="bqq2tLI5" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43GBUnbY003029; Tue, 16 Apr 2024 11:42:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=Yw+4X7+D3QMaBDckgqrpNELFhXS2gacZB6XGkFCLb6Q=; b=bqq2tLI5jv+xjUYca90X3NBpqJ4Rf7JPZHDqP5RjZlRCl6cWtDUzcA+NQIbj0Yw/bHTF askD+GrH04rryP89Da45gl/XmOlqRgwPl0Rr6GZfhrMpFO6VU3rFj5+wOwndrXHebt4y 6eIaNyDzN7KXYg0C5798MWGDxOGrStGMSwkTYfCIEwLuW85PHwMDB5lLUPgBIQ3RDTl9 43xG+DDQPRzHpbfhqbSMwRJtFHfI9mmOgXGz+m9BAeJYpNxmulo3avdNmW80vwjerWIK t08eA6iiYM/3dJYNs/VEACdf9bwmWts86mebA8FnNiWMMKmNXJmzeG0iFIw25xZv3PwN sg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhrh9g0ng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 11:42:27 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43GBgQ1d020853; Tue, 16 Apr 2024 11:42:26 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhrh9g0ne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 11:42:26 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43GAXag2011141; Tue, 16 Apr 2024 11:42:25 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xg732dd23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 11:42:25 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43GBgKjv46924144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Apr 2024 11:42:22 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 855B820040; Tue, 16 Apr 2024 11:42:20 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 587D32004B; Tue, 16 Apr 2024 11:42:20 +0000 (GMT) Received: from p-imbrenda.boeblingen.de.ibm.com (unknown [9.152.224.66]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 16 Apr 2024 11:42:20 +0000 (GMT) From: Claudio Imbrenda To: linux-s390@vger.kernel.org Cc: linux-kernel@vger.kernel.org, frankja@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com, borntraeger@de.ibm.com, hca@linux.ibm.com, gerald.schaefer@linux.ibm.com, david@redhat.com Subject: [PATCH v1 1/2] s390/mm: fix storage key clearing for guest huge pages Date: Tue, 16 Apr 2024 13:42:19 +0200 Message-ID: <20240416114220.28489-2-imbrenda@linux.ibm.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240416114220.28489-1-imbrenda@linux.ibm.com> References: <20240416114220.28489-1-imbrenda@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: X6PmzabpRkVkrlBsLeY5qts4fWxPUS2N X-Proofpoint-ORIG-GUID: Gakgpu3lF6xiqDjr56TokdkrMoNI7nnU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-16_08,2024-04-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 impostorscore=0 phishscore=0 mlxscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404160072 The function __storage_key_init_range() expects the end address to be the first byte outside the range to be initialized. I.e. end - start should be the size of the area to be initialized. The current code works because __storage_key_init_range() will still loop over every page in the range, but it is slower than using sske_frame(). Fixes: 964c2c05c9f3 ("s390/mm: Clear huge page storage keys on enable_skey") Signed-off-by: Claudio Imbrenda --- arch/s390/mm/gmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c index 094b43b121cd..12d22a7fa32f 100644 --- a/arch/s390/mm/gmap.c +++ b/arch/s390/mm/gmap.c @@ -2661,7 +2661,7 @@ static int __s390_enable_skey_hugetlb(pte_t *pte, unsigned long addr, return 0; start = pmd_val(*pmd) & HPAGE_MASK; - end = start + HPAGE_SIZE - 1; + end = start + HPAGE_SIZE; __storage_key_init_range(start, end); set_bit(PG_arch_1, &page->flags); cond_resched(); -- 2.44.0