Re: [PATCH v3 1/3] vfio/pci: Extract duplicated code into macro

Jason Gunthorpe
2024-04-29T22:33:35Z

On Mon, Apr 29, 2024 at 04:11:03PM -0600, Alex Williamson wrote:
> > This isn't very performance optimal already, we take a lock on every
> > iteration, so there isn't much point in inlining multiple copies of
> > everything to save an branch.
>
> These macros are to reduce duplicate code blocks and the errors that
> typically come from such duplication,

But there is still quite a bit of repetition here..

> as well as to provide type safe functions in the spirit of the
> ioread# and iowrite# helpers.

But it never really takes any advantage of type safety? It is making a
memcpy..

Jason