Re: [kvm-unit-tests PATCH v3 0/5] add shellcheck support

Andrew Jones
2024-05-02T08:12:55Z

On Wed, May 01, 2024 at 09:29:29PM GMT, Nicholas Piggin wrote:
> This is based on upstream directly now, not ahead of the powerpc
> series.
>
> Since v2:
> - Rebased to upstream with some patches merged.
> - Just a few comment typos and small issues (e.g., quoting
> `make shellcheck` in docs) that people picked up from the
> last round.
>
> `make shellcheck` passes with no warnings for me after this series.
> (You should be able to put patch 1 at the end without conflicts if
> you prefer to only introduce the shellcheck Makefile target when the
> tree is clean.)
>
> Thanks,
> Nick
>
> Nicholas Piggin (5):
> Add initial shellcheck checking
> shellcheck: Fix SC2155
> shellcheck: Fix SC2124
> shellcheck: Fix SC2294
> shellcheck: Suppress various messages
>
> .shellcheckrc | 30 ++++++++++++++++++++++++++++++
> Makefile | 4 ++++
> README.md | 3 +++
> configure | 2 ++
> run_tests.sh | 3 +++
> scripts/arch-run.bash | 33 ++++++++++++++++++++++++++-------
> scripts/common.bash | 5 ++++-
> scripts/mkstandalone.sh | 2 ++
> scripts/runtime.bash | 6 +++++-
> 9 files changed, 79 insertions(+), 9 deletions(-)
> create mode 100644 .shellcheckrc
>
> --
> 2.43.0
>

Merged.

Thanks,
drew