Re: [PATCH] mm: Remove mm argument from mm_get_unmapped_area()

Edgecombe, Rick P
2024-05-07T13:51:07Z

On Mon, 2024-05-06 at 12:32 -0400, Liam R. Howlett wrote:
>
> I like this patch.

Thanks for taking a look.

>
> I think the context of current->mm is implied. IOW, could we call it
> get_unmapped_area() instead?  There are other functions today that use
> current->mm that don't start with current_<whatever>.  I probably should
> have responded to Dan's suggestion with my comment.

Yes, get_unmapped_area() is already taken. What else to call it... It is kind of
the process "default" get_unmapped_area(). But with Christoph's proposal it
would basically be arch_get_unmapped_area().

>
> Either way, this is a minor thing so feel free to add:
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>