Re: [PATCH] mm: Remove mm argument from mm_get_unmapped_area()

Liam R. Howlett
2024-05-07T16:06:55Z

* Edgecombe, Rick P <rick.p.edgecombe@intel.com> [240507 09:51]:
> On Mon, 2024-05-06 at 12:32 -0400, Liam R. Howlett wrote:
> >
> > I like this patch.
>
> Thanks for taking a look.
>
> >
> > I think the context of current->mm is implied. IOW, could we call it
> > get_unmapped_area() instead?  There are other functions today that use
> > current->mm that don't start with current_<whatever>.  I probably should
> > have responded to Dan's suggestion with my comment.
>
> Yes, get_unmapped_area() is already taken. What else to call it... It is kind of
> the process "default" get_unmapped_area(). But with Christoph's proposal it
> would basically be arch_get_unmapped_area().

unmapped_area(), but that's also taken..

arch_get_unmapped_area() are all quite close. If you look into it, many
of the arch versions were taken from the sparc 32 version. Subsequent
changes were made and they are no longer exactly the same, but I believe
functionally equivalent - rather tricky to test though.

I wanted to unite these to simplify the mm code a while back, but have
not gotten back to it. One aspect that some archs have is "cache
coloring" which does affect the VMAs.

The other difference is VDSO, which I may be looking into soon. Someone
once called me a glutton for punishment and there may be some truth in
that...

Cheers,
Liam