Re: [kvm-unit-tests PATCH 3/4] s390x: Move SIE assembly into new file

Christoph Schlameuss
2024-07-25T14:34:19Z

On Thu, 18 Jul 2024 10:50:18 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> In contrast to the other functions in cpu.S it's quite lengthy so
> let's split it off.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/Makefile | 2 +-
> s390x/{cpu.S => cpu-sie.S} | 59 +----------------------------------
> s390x/cpu.S | 64 --------------------------------------
> 3 files changed, 2 insertions(+), 123 deletions(-)
> copy s390x/{cpu.S => cpu-sie.S} (56%)

[...]

> diff --git a/s390x/cpu.S b/s390x/cpu-sie.S
> similarity index 56%
> copy from s390x/cpu.S
> copy to s390x/cpu-sie.S
> index 9155b044..9370b5c0 100644
> --- a/s390x/cpu.S
> +++ b/s390x/cpu-sie.S
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> /*
> - * s390x assembly library
> + * s390x SIE assembly library
> *
> * Copyright (c) 2019 IBM Corp.
> *

Should we not also update the Copyright here? At least to
"Copyright (c) 2019, 2024 IBM Corp."? …