Re: [kvm-unit-tests PATCH 2/4] s390x/Makefile: Add more comments

Claudio Imbrenda
2024-07-25T14:40:54Z

On Thu, 18 Jul 2024 10:50:17 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> More comments in Makefiles can only make them more approachable.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
> s390x/Makefile | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/s390x/Makefile b/s390x/Makefile
> index 2933b452..457b8455 100644
> --- a/s390x/Makefile
> +++ b/s390x/Makefile
> @@ -50,12 +50,15 @@ pv-tests += $(TEST_DIR)/pv-icptcode.elf
> pv-tests += $(TEST_DIR)/pv-ipl.elf
> pv-tests += $(TEST_DIR)/pv-edat1.elf
>
> +# Add PV host tests if we're able to generate them
> +# The host key document and a tool to generate SE headers are the prerequisite
> ifneq ($(HOST_KEY_DOCUMENT),)
> ifneq ($(GEN_SE_HEADER),)
> tests += $(pv-tests)
> endif
> endif
>
> +# Add binary flat images for use in non-KVM hypervisors
> tests_binary = $(patsubst %.elf,%.bin,$(tests))
> ifneq ($(HOST_KEY_DOCUMENT),)
> tests_pv_binary = $(patsubst %.bin,%.pv.bin,$(tests_binary))
> @@ -142,6 +145,7 @@ $(TEST_DIR)/pv-icptcode.elf: pv-snippets += $(SNIPPET_DIR)/asm/pv-icpt-vir-timin
> $(TEST_DIR)/pv-ipl.elf: pv-snippets += $(SNIPPET_DIR)/asm/pv-diag-308.gbin
> $(TEST_DIR)/pv-edat1.elf: pv-snippets += $(SNIPPET_DIR)/c/pv-memhog.gbin
>
> +# Add PV tests and snippets if GEN_SE_HEADER is set
> ifneq ($(GEN_SE_HEADER),)
> snippets += $(pv-snippets)
> tests += $(pv-tests)
> @@ -150,6 +154,7 @@ else
> snippet-hdr-obj =
> endif
>
> +# Generate loader script
> lds-autodepend-flags = -MMD -MF $(dir $*).$(notdir $*).d -MT $@
> %.lds: %.lds.S $(asm-offsets)
> $(CPP) $(lds-autodepend-flags) $(CPPFLAGS) -P -C -o $@ $<