Re: [kvm-unit-tests PATCH 1/4] s390x: Split snippet makefile rules into new file

Janosch Frank
2024-08-02T09:34:12Z

On 7/25/24 4:27 PM, Christoph Schlameuss wrote:
> On Thu, 18 Jul 2024 10:50:16 +0000
> Janosch Frank <frankja@linux.ibm.com> wrote:
>
>> It's time to move the snippet related Makefile parts into a new file
>> to make s390x/Makefile less busy.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> s390x/Makefile | 34 ++++------------------------------
>> s390x/snippets/Makefile | 30 ++++++++++++++++++++++++++++++
>> 2 files changed, 34 insertions(+), 30 deletions(-)
>> create mode 100644 s390x/snippets/Makefile
>
> IMHO the commit message should start with "s390x/Makefile: Split snippet
> makefile rules into new file" for more consistency.
>
> With that fixed:
> Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

Sure
I'll send a new version around anyway, since I've rebased the series on
Marc's make file patch.