Re: [PATCH 14/17] mm: introduce numa_emulation

Mike Rapoport
2024-07-20T12:12:37Z

On Fri, Jul 19, 2024 at 12:03:11PM -0400, Zi Yan wrote:
> On 16 Jul 2024, at 7:13, Mike Rapoport wrote:
>
> > From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
> >
> > Move numa_emulation codfrom arch/x86 to mm/numa_emulation.c
> >
> > This code will be later reused by arch_numa.
> >
> > No functional changes.
> >
> > Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> > ---
> > arch/x86/Kconfig | 8 --------
> > arch/x86/include/asm/numa.h | 12 ------------
> > arch/x86/mm/Makefile | 1 -
> > arch/x86/mm/numa_internal.h | 11 -----------
> > include/linux/numa_memblks.h | 17 +++++++++++++++++
> > mm/Kconfig | 8 ++++++++
> > mm/Makefile | 1 +
> > mm/numa_emulation.c | 4 +---
> > 8 files changed, 27 insertions(+), 35 deletions(-)
>
> After this code move, the document of numa=fake= should be moved from
> Documentation/arch/x86/x86_64/boot-options.rst to
> Documentation/admin-guide/kernel-parameters.txt
> too.

I'll add this as a separate commit.

> Something like:
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index bc55fb55cd26..ce3659289b5e 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4158,6 +4158,18 @@
> Disable NUMA, Only set up a single NUMA node
> spanning all memory.
>
> + numa=fake=<size>[MG]
> + If given as a memory unit, fills all system RAM with nodes of
> + size interleaved over physical nodes.
> +
> + numa=fake=<N>
> + If given as an integer, fills all system RAM with N fake nodes
> + interleaved over physical nodes.
> +
> + numa=fake=<N>U
> + If given as an integer followed by 'U', it will divide each
> + physical node into N emulated nodes.
> +
> numa_balancing= [KNL,ARM64,PPC,RISCV,S390,X86] Enable or disable automatic
> NUMA balancing.
> Allowed values are enable and disable
> diff --git a/Documentation/arch/x86/x86_64/boot-options.rst b/Documentation/arch/x86/x86_64/boot-options.rst
> index 137432d34109..98d4805f0823 100644
> --- a/Documentation/arch/x86/x86_64/boot-options.rst
> +++ b/Documentation/arch/x86/x86_64/boot-options.rst
> @@ -170,18 +170,6 @@ NUMA
> Don't parse the HMAT table for NUMA setup, or soft-reserved memory
> partitioning.
>
> - numa=fake=<size>[MG]
> - If given as a memory unit, fills all system RAM with nodes of
> - size interleaved over physical nodes.
> -
> - numa=fake=<N>
> - If given as an integer, fills all system RAM with N fake nodes
> - interleaved over physical nodes.
> -
> - numa=fake=<N>U
> - If given as an integer followed by 'U', it will divide each
> - physical node into N emulated nodes.
> -
> ACPI
> ====
>
> Best Regards,
> Yan, Zi

--
Sincerely yours,
Mike.