Re: [PATCH v2 02/10] selftests: kvm: s390: Add kvm_s390_sie_block definition for userspace tests

Janosch Frank
2024-07-24T14:39:46Z

On 7/23/24 11:31, Christoph Schlameuss wrote:
> Subsequent tests do require direct manipulation of the SIE instruction.
> This commit introduces the SIE definition for the selftests.

AFAIK ucontrol doesn't allow to manipulate the instruction, it allows
manipulation of the *SIE control block* that's handed over as an operand
to SIE.

>
> There are already definitions of this within the kernel.
> This differs in two ways.
> * This is the first definition of this in userspace.
> * This does not require atomicity for the flags.
>
> With the userspace definition of the SIE block layout now being present
> we can reuse the values in other tests where applicable.
>
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

Code looks fine though.