Re: [PATCH v3 21/26] mm: numa_memblks: make several functions and variables static

Jonathan Cameron
2024-08-02T11:10:23Z

On Thu, 1 Aug 2024 09:08:21 +0300
Mike Rapoport <rppt@kernel.org> wrote:

> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> Make functions and variables that are exclusively used by numa_memblks
> static.
>
> Move numa_nodemask_from_meminfo() before its callers to avoid forward
> declaration.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> Tested-by: Zi Yan <ziy@nvidia.com> # for x86_64 and arm64
Good. I was wondering why some of this internal detail was in the header.
Much nicer after this.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>