Re: [PATCH] s390/vfio-ap: Driver feature advertisement

Heiko Carstens
2024-09-09T12:42:06Z

On Mon, Sep 09, 2024 at 08:02:17AM -0400, Jason J. Herne wrote:
> On 9/6/24 6:45 AM, Heiko Carstens wrote:
> > On Thu, Sep 05, 2024 at 08:43:51AM -0400, Jason J. Herne wrote:
> > > Advertise features of the driver for the benefit of automated tooling
> > > like Libvirt and mdevctl.
> > >
> > > Signed-off-by: Jason J. Herne <jjherne@linux.ibm.com>
> > > Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
> > > ---
> > > Documentation/arch/s390/vfio-ap.rst | 34 +++++++++++++++++++++++++++++
> > > drivers/s390/crypto/vfio_ap_drv.c | 13 +++++++++++
> > > 2 files changed, 47 insertions(+)
> >
> > Via which tree should this go upstream?
> >
> I'm not 100% sure. Would s390 next be appropriate?

Well that's up to you to decide; no objection from my side.

FWIW it would be helpful if for future patches there would be a
statement in the cover-letter how this should go upstream. Also
looking at the "To" list of your patch I don't think anybody would
feel like there is a todo :)

That said, you still need to send a v2 which replaces sprintf() with
sysfs_emit().