Re: [PATCH v3 5/6] s390/uvdevice: Add List Secrets Ext IOCTL

Heiko Carstens
2024-10-15T12:01:16Z

On Tue, Oct 15, 2024 at 01:28:58PM +0200, Steffen Eiden wrote:
> Add an extended List Secrets IOCTL. In contrast to the first list IOCTL
> this accepts an index as the first two bytes of the provided page as an
> input. This index is then taken as the index offset for the list UVC to
> receive later entries for the list. While at it fix some kernel doc
> issues with the list function.
>
> Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
> ---
> arch/s390/include/uapi/asm/uvdevice.h | 4 ++
> drivers/s390/char/uvdevice.c | 96 +++++++++++++++++++--------
> 2 files changed, 72 insertions(+), 28 deletions(-)

...

> +/**
> + * The actual list(_ext) IOCTL.
> + * If list_ext is true, the first two bytes of the user buffer set the starting
> + * index of the list-UVC.
> + */
> +static int list_secrets(struct uvio_ioctl_cb *uv_ioctl, bool list_ext)

This is not kernel-doc style :)

> + free_pages((unsigned long)secrets, 0);
> + return ret;

free_page() instead of free_pages()?