From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C081C5CDD; Wed, 18 Dec 2024 15:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734534519; cv=none; b=c/IZBRJ8G7DIGADopQACfcu5RS4vj3Id0JE0jOp2ih4Yn+JGUQx9AWzhbebC9MPipQ4Fod8FGJqplGMlCu7UEJ6xW6S86u9bKpDIZqDALJwsuOLuN3kmHx3UAj2hPFZep4Qr7x3wUxSdtGYj5KsQW5FXyj1DGdOggVBsKAF3dLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734534519; c=relaxed/simple; bh=dsz8257D+6as1uUtKCRNXMXuyupbAqskFTKy5dqOl5Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oyrHnn6YoSXStwWMOmxiDNu27gM+vN3QGW1Q7BHK/9J/shrppdlQLNHVIDRl1wmtdU9bfhy+optFXy07E/XrVfkltvb3T/YOelQPpLtuRnjw1lSJYEkQ0DDWSOVGI4ko0NxS8EJ1nu0emyuwgQBJFjb2eL/pvU/+DLpZXO17aPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DOFYmV/O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DOFYmV/O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31A23C4CECE; Wed, 18 Dec 2024 15:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734534519; bh=dsz8257D+6as1uUtKCRNXMXuyupbAqskFTKy5dqOl5Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DOFYmV/OC+pxzzSN2F3KRoWuPa3RBYPTcC/zoOH2NCKjp1MeXanV999doe0z17HZ9 kZeRFu9n52HpxIYfDvjY68cwj2dFjby7xXYHkkhE6r1WCfyp9XvKDBOdii0weYJCm+ 9xKCOdfjiu4YgHKWSLJx0oNXIh9y/gozVqQ4FgrGJap66A/Q1lO5Vt/tWoIGECJlWH Rp7OGHr4sDQ+63bPykzZvg4/ERY2JHbLdJSx7PfB1jdfh7ai0OGgoE0GCVZHUb6g+l lHS+ibQI7IPTVeyzL3d/9mjIO74XkR3qFvTP3HJ4GhKXpeqZidOrYIhtpJAdAEabhd m0OkMY0OfPMpw== Date: Wed, 18 Dec 2024 15:08:28 +0000 From: Conor Dooley To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: "James E.J. Bottomley" , Helge Deller , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Anna-Maria Behnsen , Frederic Weisbecker , Andrew Morton , Catalin Marinas , Will Deacon , Theodore Ts'o , "Jason A. Donenfeld" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , WANG Xuerui , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Arnd Bergmann , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, linux-s390@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org, Nam Cao Subject: Re: [PATCH 07/17] riscv: vdso: Switch to generic storage implementation Message-ID: <20241218-action-matchbook-571b597b7f55@spud> References: <20241216-vdso-store-rng-v1-0-f7aed1bdb3b2@linutronix.de> <20241216-vdso-store-rng-v1-7-f7aed1bdb3b2@linutronix.de> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fu8z2+BbmIxUgToy" Content-Disposition: inline In-Reply-To: <20241216-vdso-store-rng-v1-7-f7aed1bdb3b2@linutronix.de> --fu8z2+BbmIxUgToy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 16, 2024 at 03:10:03PM +0100, Thomas Wei=DFschuh wrote: > The generic storage implementation provides the same features as the > custom one. However it can be shared between architectures, making > maintenance easier. >=20 > Co-developed-by: Nam Cao > Signed-off-by: Nam Cao > Signed-off-by: Thomas Wei=DFschuh > --- > arch/riscv/Kconfig | 3 +- > arch/riscv/include/asm/vdso.h | 2 +- > .../include/asm/vdso/{time_data.h =3D> arch_data.h} | 8 +- > arch/riscv/include/asm/vdso/gettimeofday.h | 14 +--- > arch/riscv/include/asm/vdso/vsyscall.h | 9 --- > arch/riscv/kernel/sys_hwprobe.c | 3 +- > arch/riscv/kernel/vdso.c | 90 +---------------= ------ > arch/riscv/kernel/vdso/hwprobe.c | 6 +- > arch/riscv/kernel/vdso/vdso.lds.S | 7 +- > 9 files changed, 18 insertions(+), 124 deletions(-) Fails to build: Patch 7/17: Test 1/12: .github/scripts/patches/tests/build_rv32_defconfig.sh /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:11:33: warning: de= claration of 'struct riscv_hwprobe' will not be visible outside of this fun= ction [-Wvisibility] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:15:41: warning: de= claration of 'struct riscv_hwprobe' will not be visible outside of this fun= ction [-Wvisibility] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:19:37: error: call= to undeclared function '__arch_get_vdso_u_arch_data'; ISO C99 and later do= not support implicit function declarations [-Wimplicit-function-declaratio= n] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:19:31: error: inco= mpatible integer to pointer conversion initializing 'const struct vdso_arch= _data *' with an expression of type 'int' [-Wint-conversion] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:22:36: error: arit= hmetic on a pointer to an incomplete type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:30:40: error: inco= mplete definition of type 'const struct vdso_arch_data' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:31:24: error: inco= mpatible pointer types passing 'struct riscv_hwprobe *' to parameter of typ= e 'struct riscv_hwprobe *' [-Werror,-Wincompatible-pointer-types] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:35:7: error: call = to undeclared function 'riscv_hwprobe_key_is_valid'; ISO C99 and later do n= ot support implicit function declarations [-Wimplicit-function-declaration] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:35:35: error: inco= mplete definition of type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:36:5: error: incom= plete definition of type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:36:18: error: inco= mplete definition of type 'const struct vdso_arch_data' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:36:44: error: inco= mplete definition of type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:39:5: error: incom= plete definition of type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:40:5: error: incom= plete definition of type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:43:4: error: arith= metic on a pointer to an incomplete type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:49:39: warning: de= claration of 'struct riscv_hwprobe' will not be visible outside of this fun= ction [-Wvisibility] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:53:37: error: call= to undeclared function '__arch_get_vdso_u_arch_data'; ISO C99 and later do= not support implicit function declarations [-Wimplicit-function-declaratio= n] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:53:31: error: inco= mpatible integer to pointer conversion initializing 'const struct vdso_arch= _data *' with an expression of type 'int' [-Wint-conversion] /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:55:36: error: arit= hmetic on a pointer to an incomplete type 'struct riscv_hwprobe' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:71:61: error: inco= mplete definition of type 'const struct vdso_arch_data' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:71:29: error: use = of undeclared identifier 'RISCV_HWPROBE_WHICH_CPUS' /build/tmp.cAQOaMfDA3/arch/riscv/kernel/vdso/hwprobe.c:72:24: error: inco= mpatible pointer types passing 'struct riscv_hwprobe *' to parameter of typ= e 'struct riscv_hwprobe *' [-Werror,-Wincompatible-pointer-types] fatal error: too many errors emitted, stopping now [-ferror-limit=3D] Might be a clang thing, allmodconfig with clang doesn't build either. --fu8z2+BbmIxUgToy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ2LlbAAKCRB4tDGHoIJi 0n2PAQDyBQBbIhWl4PuPh0Arh+dY5o5V02LpT/vyZTOInKNMcgEAqZD+a5hkxJEH lFXI4u2esepSVEUEOeQQYFauBervVQc= =gqd2 -----END PGP SIGNATURE----- --fu8z2+BbmIxUgToy--