Re: [PATCH v1 0/4] KVM: s390: vsie: vsie page handling fixes + rework

David Hildenbrand
2025-01-08T20:42:29Z

On 08.01.25 19:21, Claudio Imbrenda wrote:
> On Tue, 7 Jan 2025 16:43:40 +0100
> David Hildenbrand <david@redhat.com> wrote:
>
>> We want to get rid of page->index, so let's make vsie code stop using it
>> for the vsie page.
>>
>> While at it, also remove the usage of page refcount, so we can stop messing
>> with "struct page" completely.
>>
>> ... of course, looking at this code after quite some years, I found some
>> corner cases that should be fixed.
>>
>> Briefly sanity tested with kvm-unit-tests running inside a KVM VM, and
>> nothing blew up.
>
> I like this! (aside from a very tiny nit in patch 4)

Thanks for the review!

>
> if a v2 is not needed, I'll put the split line in patch 4 back together
> myself when picking, no need to send a v2 just for that.

Yeah, that might be a case where "significantly increases readability"
might still apply.

--
Cheers,

David / dhildenb