From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C1251C5D45 for ; Mon, 13 Jan 2025 15:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736781230; cv=none; b=GhJqaRCh16/sTBHMEj+Sl6kM34cqbn166EMYpI81gOkpGHs8m4Hg9ARkHJ2edErdvnZrMtxWzDryEquOrDj4JzJsrPsYBFFV3QGws3haihjD9cifCrjM3vKGaZG0HBZKDrAY5DssBuEITGOmgB60fhFAy01cnZELAKaQWVLPtjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736781230; c=relaxed/simple; bh=KaHlhsrtv4K/tHjLxuhxWmktncbZPNh72xHAYkNsAsI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kFyWojI7z5ipJupOcoFbB/eEbieU4oFNUjxTMbr4A4vABabdXr6Z8WI23BjFj9JqeDPnFV2TAKooMPAjdEpUIBNfvY/d7Qyk3aMByv/zBWRfkBnC4TtQ2LXFaRu94nPWgWtSOi7UJEoddrbuGSGDrZhwSOuW5UdCbq/4iGqEAaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fXT1uUBo; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fXT1uUBo" Date: Mon, 13 Jan 2025 16:13:41 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736781224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hdLeZjgsxpTEb/ESjCgEojXnaXa6y+7iB6h33/Z6dms=; b=fXT1uUBoKArx52tPaWyXs+o2K25Q1zXgNMni985Mil56OjK89u7UWgd4+JToG7xCNI5AOE ItO1kOrctTaGYtt54+Sl82Hm/4Z1q1QjFH4kYR9z8T+xyBgaxDW/Pt4j0PHEbPWFsvz45b yMhV/l3rnHfZB2C1X6EVTCpchLdp9PI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Alexandru Elisei Cc: eric.auger@redhat.com, lvivier@redhat.com, thuth@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, nrb@linux.ibm.com, david@redhat.com, pbonzini@redhat.com, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org, vladimir.murzin@arm.com Subject: Re: [kvm-unit-tests PATCH v1 3/5] arm64: Implement the ./configure --processor option Message-ID: <20250113-095d3fc41114359b246608e0@orel> References: <20250110135848.35465-1-alexandru.elisei@arm.com> <20250110135848.35465-4-alexandru.elisei@arm.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250110135848.35465-4-alexandru.elisei@arm.com> X-Migadu-Flow: FLOW_OUT On Fri, Jan 10, 2025 at 01:58:46PM +0000, Alexandru Elisei wrote: > The help text for the ./configure --processor option says: > > --processor=PROCESSOR processor to compile for (cortex-a57) > > but, unlike arm, the build system does not pass a -mcpu argument to the > compiler. Fix it, and bring arm64 at parity with arm. > > Note that this introduces a regression, which is also present on arm: if > the --processor argument is something that the compiler doesn't understand, > but qemu does (like 'max'), then compilation fails. This will be fixed in a > following patch; another fix is to specify a CPU model that gcc implements > by using --cflags=-mcpu=. > > Signed-off-by: Alexandru Elisei > --- > arm/Makefile.arm | 1 - > arm/Makefile.common | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arm/Makefile.arm b/arm/Makefile.arm > index 7fd39f3ada64..d6250b7fb686 100644 > --- a/arm/Makefile.arm > +++ b/arm/Makefile.arm > @@ -12,7 +12,6 @@ $(error Cannot build arm32 tests as EFI apps) > endif > > CFLAGS += $(machine) > -CFLAGS += -mcpu=$(PROCESSOR) > CFLAGS += -mno-unaligned-access > > ifeq ($(TARGET),qemu) > diff --git a/arm/Makefile.common b/arm/Makefile.common > index f828dbe01d33..a5d97bcf477a 100644 > --- a/arm/Makefile.common > +++ b/arm/Makefile.common > @@ -25,6 +25,7 @@ AUXFLAGS ?= 0x0 > # stack.o relies on frame pointers. > KEEP_FRAME_POINTER := y > > +CFLAGS += -mcpu=$(PROCESSOR) > CFLAGS += -std=gnu99 > CFLAGS += -ffreestanding > CFLAGS += -O2 > -- > 2.47.1 > Reviewed-by: Andrew Jones