Re: [PATCH v1 1/1] dm-integrity: Implement asynch digest support

Herbert Xu
2025-01-16T09:13:06Z

On Thu, Jan 16, 2025 at 10:00:36AM +0100, Harald Freudenberger wrote:
>
> Eric your idea was whirling around in my head for at least 3 month now.
> It would be great to have a way to offer an shash() implementation which
> clearly states that it is not for use in atomic context. E.g. like as you
> wrote with a new flag. I'll work out something in this direction and push
> it onto the crypto mailing list :-)

I don't like this flag because we'd have to modify every other
hash user. For example, this would result in your algorithm
being unavailable to IPsec despite it being an ahash user (because
it can't sleep).

I think the dm-crypt patch should wait until after I have added
virtual address support to ahash. Then we could compare it properly
with shash.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt