From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4814214A98 for ; Thu, 27 Mar 2025 14:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743086393; cv=none; b=TC82WDr/obT7WKlR7ADgI/U+Ye74wyEAscFOUATYPMJ9q8p3eMnW13Tcc9a+nZ0CaJbW5+kcw7OXXofeq37uQIlGJIxuOLlCICGb9yfGrqybsQHu3NPURXBB8hbF6/kZup/D5DwJLmRAOAs8f/W5LFM8kOEkn9v/dJO9L2YvawI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743086393; c=relaxed/simple; bh=vsieCJLLJBjxDlgo6zegm5m/cDFTeI7yWzYUTVlapI8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qWO5J59pIhp79ecHfRs9xGWko0BQkI8QWJe00yKRPaaSVoYzK1Opowj4mLJB03ifnpVxBhgv5kRpcSzWo/TPd28hAcRdxxOtsDB7gPCImh6IZFL0UD7LqhnS3162/yqUu9lE1jzkp1CFc1OgqFXUgsRzSLQ/Wme7KAJTWa3JaiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=UdUTDkeh; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="UdUTDkeh" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52R5vgd0017410; Thu, 27 Mar 2025 14:39:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=avIBYvQnJZKd6ZXGqJz9hLNesh+bHNs/ccMTeDFui Xg=; b=UdUTDkehqSMsXRjfri3bQHRPveOn1e6toJdq7DVFN47NwOfsyDJ99e9g5 KvfUJkJfHNJEQBH/KPX6DN2NwOWcMLAIIZuGh1cqIII5Ixy6oSYvHv/A/yyRaDTr ClZP+ntRWxCHdpZh2YvQKzQuLLDFWbRb4t5HvpFon8JD/p9x/HZIGrbPDuoq0vc2 rwFHvAuRXjLM7O3P2grCss0SzCylitYaEL1z+rusPSAkpzHNp03GYy6XNa9XOOQS R6PDzz0yYKBtCOERmP0Nw+OS/n9nSqVpDwAcqnRWCV9dXWqNbFhr+/qwD1h5rhza S6WNgw/eTkvClDNFB2Ul47XjQfZtw== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45mnrwnfr3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Mar 2025 14:39:47 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52RB1N7L025478; Thu, 27 Mar 2025 14:39:46 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 45j7x0dw8t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Mar 2025 14:39:46 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52REdgvq34669166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Mar 2025 14:39:42 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A79B620040; Thu, 27 Mar 2025 14:39:42 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F9DF2004D; Thu, 27 Mar 2025 14:39:42 +0000 (GMT) Received: from funtu2.fritz.box?044ibm.com (unknown [9.171.80.24]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Mar 2025 14:39:42 +0000 (GMT) From: Harald Freudenberger To: dengler@linux.ibm.com, ifranzki@linux.ibm.com, fcallies@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com Cc: linux-s390@vger.kernel.org, herbert@gondor.apana.org.au Subject: [PATCH v3 00/21] AP bus/zcrypt/pkey/paes no-mem-alloc patches Date: Thu, 27 Mar 2025 15:39:20 +0100 Message-ID: <20250327143941.45507-1-freude@linux.ibm.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Le2wd_j2qhjcgfX-It_b1c7QJihxV5wd X-Proofpoint-ORIG-GUID: Le2wd_j2qhjcgfX-It_b1c7QJihxV5wd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-27_01,2025-03-26_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503270099 This series of patches has the goal to open up a do-not-allocate memory path from the callers of the pkey in-kernel api down to the crypto cards and back. The asynch in-kernel cipher implementations (and the s390 PAES cipher implementations are one of them) may be called in a context where memory allocations which trigger IO is not acceptable. So this patch series reworks the AP bus code, the zcrypt layer, the pkey layer and the pkey handlers to respect this situation by processing a new parameter xflags (execution hints flags). There is a flag PKEY_XFLAG_NOMEMALLOC which tells the code to not allocate memory which may lead to IO operations. To reach this goal, the actual code changes have been differed. The zcrypt misc functions which need memory for cprb build use a pre allocated memory pool for this purpose. The findcard() functions have one temp memory area preallocated and protected with a mutex. Some smaller data is not allocated any more but went to the stack instead. The AP bus also uses a pre-allocated memory pool for building AP message requests. Note that the PAES implementation still needs to get reworked to run the protected key derivation in a real asynchronous way. However, this rework of AP bus, zcrypt and pkey is the base work required before reconsidering the PAES implementation. The patch series starts bottom (AP bus) and goes up the call chain (PKEY). At any time in the patch stack it should compile. For easier review I tried to have one logic code change by each patch and thus keep the patches "small". For the upstream version I intend to fold them together into only a few commits. Changelog: v1: initial version v2: - Rework on patch 0001 and 0002 based on feedback from Holger. Also there was one place in zcrypt_msgtype50.c where still an ap msg buffer was alloacated. - Rework on patch 0003 - fixed feedback from Holger. Also the min poolitems is now a module parameter and defaults to 8. - Rework on patch 0004 - as suggested by Holger the "userspace" parameter is now included into the ap msg flags. - Rework on patch 0005 - nr of cca cprbs in the mempool is now a module parameter. - Rework on patch 0006 - nr of ep11 cprbs in the mempool is now a module parameter. - Rework on patch 0007 - as suggested by Holger instead of implementing a copy-and-pasted new function zcrypt_device_status_mask_ext2() use and extend the existing the existing function to avoid code duplication. - The rest of the patch series needed adaptions but there is no functional change compared to v1. v3: Rework based on feedback from Holger: - There is now one zcrypt module parameter "mempool_threshold" controlling the cprb mempools for CCA and EP11. The default value of 5 shall cover 5 CCA or EP11 requests/replies in parallel. - The cca and ep11 card and domain info cache is done - anyway nearly all callers used the verify=1 to enforce the retrieval of fresh information. So now this info is always freshly fetched from the card/domain. - Holger found out that there are some unused functions lurking around - deleted :-) - The only thing still missing is no-mem support for the UV driver. As of now the pkey uv layer refuses to contact the UV dd in case the NOMEMALLOC flag is given. - Tested and found no issues. Harald Freudenberger (21): s390/ap: Move response_type struct into ap_msg struct s390/ap/zcrypt: Rework AP message buffer allocation s390/ap: Introduce ap message buffer pool s390/ap/zcrypt: New xflag parameter s390/zcrypt: Introduce cprb mempool for cca misc functions s390/zcrypt: Introduce cprb mempool for ep11 misc functions s390/zcrypt: Rework zcrypt function zcrypt_device_status_mask_ext s390/zcrypt: Introduce pre-allocated device status array for cca misc s390/zcrypt: Introduce pre-allocated device status array for ep11 misc s390/zcrypt: Remove unused functions from cca misc s390/zcrypt: Remove CCA and EP11 card and domain info caches s390/zcrypt/pkey: Rework cca findcard() implementation and callers s390/zcrypt/pkey: Rework ep11 findcard() implementation and callers s390/zcrypt: Rework cca misc functions kmallocs to use the cprb mempool s390/zcrypt: Propagate xflags argument with cca_get_info() s390/zcrypt: Locate ep11_domain_query_info onto the stack instead of kmalloc s390/zcrypt: Rework ep11 misc functions to use cprb mempool s390/pkey: Rework CCA pkey handler to use stack for small memory allocs s390/pkey: Rework EP11 pkey handler to use stack for small memory allocs s390/zcrypt/pkey: Provide and pass xflags within pkey and zcrypt layers s390/pkey/crypto: Introduce xflags param for pkey in-kernel API arch/s390/crypto/paes_s390.c | 2 +- arch/s390/include/asm/pkey.h | 15 +- drivers/s390/crypto/ap_bus.c | 73 ++++ drivers/s390/crypto/ap_bus.h | 30 +- drivers/s390/crypto/pkey_api.c | 54 +-- drivers/s390/crypto/pkey_base.c | 34 +- drivers/s390/crypto/pkey_base.h | 37 +- drivers/s390/crypto/pkey_cca.c | 121 +++--- drivers/s390/crypto/pkey_ep11.c | 106 +++--- drivers/s390/crypto/pkey_pckmo.c | 9 +- drivers/s390/crypto/pkey_sysfs.c | 4 +- drivers/s390/crypto/pkey_uv.c | 16 +- drivers/s390/crypto/zcrypt_api.c | 148 +++++--- drivers/s390/crypto/zcrypt_api.h | 16 +- drivers/s390/crypto/zcrypt_ccamisc.c | 486 +++++++++---------------- drivers/s390/crypto/zcrypt_ccamisc.h | 49 +-- drivers/s390/crypto/zcrypt_cex4.c | 39 +- drivers/s390/crypto/zcrypt_ep11misc.c | 459 +++++++++++------------ drivers/s390/crypto/zcrypt_ep11misc.h | 27 +- drivers/s390/crypto/zcrypt_msgtype50.c | 36 +- drivers/s390/crypto/zcrypt_msgtype6.c | 109 +++--- 21 files changed, 898 insertions(+), 972 deletions(-) base-commit: a59fa56c6342f6cac1e37a4a525fbb36b99063ae -- 2.43.0