From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84809206F19; Fri, 4 Apr 2025 00:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743725241; cv=none; b=X0BGpJsT8jdk9ONHqA7l+HHtU3xzGMpmx2O1ef9E0D3vGcB0Z47CPzyH+KlhhmCBpIgbQ61aLfKXkJN5VSwHA2587y42xGjxli/nuPMFaJt7Qn4SJ1WE7sVXkRdDyPiUIvJbHLgL/qPlHdSiL1fv23D4U+5bYY/E3Baoc8knesY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743725241; c=relaxed/simple; bh=mk+yGaMYbXEcpKulZAEG/o59etxEz+0+S7aN3CTTJd8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eWxI4iTXs54S56qbHU5Gx/NciFPXVW4Z8bxdBOpfNAn69BJn8eBQocPFlN4x595KWmggpoHlprZVtlX4JFwW9x1LjqsMF3JwYNhJWrsOOHkn3HD+asCPaqiQ4Yty9BuhT2gQIzQRPQIxqbN7Zuf/9B/FMok60SXkYwGzTtd9aiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I/XrLSlk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I/XrLSlk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8368AC4CEE5; Fri, 4 Apr 2025 00:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743725241; bh=mk+yGaMYbXEcpKulZAEG/o59etxEz+0+S7aN3CTTJd8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I/XrLSlku/Dl+6cNffIYJaFXKGAq91p4vHHHIbojmJnyjdDKGdB1FBkUa+nMYQj2I RezsBq3hNjIzdnPerBhqr+WdujO2Wgeqm9PTAtgSdE2ZWMEpMwC0iOfoKeYPPsqLuz feZFPP9QXAkULrN7+vQpc3WcMjbhexM46iI3hoYwpTPmGSkjEtbY8hLhe2jsidi4N0 Cv5Wr3M/NTXYyIWfXng8jiKXr3WYFxm6PX/d/tYT4EuRzd6wISgTNYfUptglJ/l/7k moWEE1uDxHaIgssnJ+XWMhP7DcJNtlPpe/Mh8II5r+C61z5pmvvb2C5WnWTT++p+J9 NPaT61YFB2TGg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Haoxiang Li , Heiko Carstens , Vasily Gorbik , Sasha Levin , agordeev@linux.ibm.com, linux-s390@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 08/10] s390/sclp: Add check for get_zeroed_page() Date: Thu, 3 Apr 2025 20:06:58 -0400 Message-Id: <20250404000700.2689158-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250404000700.2689158-1-sashal@kernel.org> References: <20250404000700.2689158-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.132 Content-Transfer-Encoding: 8bit From: Haoxiang Li [ Upstream commit 3db42c75a921854a99db0a2775814fef97415bac ] Add check for the return value of get_zeroed_page() in sclp_console_init() to prevent null pointer dereference. Furthermore, to solve the memory leak caused by the loop allocation, add a free helper to do the free job. Signed-off-by: Haoxiang Li Acked-by: Heiko Carstens Link: https://lore.kernel.org/r/20250218025216.2421548-1-haoxiang_li2024@163.com Signed-off-by: Vasily Gorbik Signed-off-by: Sasha Levin --- drivers/s390/char/sclp_con.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/s390/char/sclp_con.c b/drivers/s390/char/sclp_con.c index e5d947c763ea5..6a030ba38bf36 100644 --- a/drivers/s390/char/sclp_con.c +++ b/drivers/s390/char/sclp_con.c @@ -263,6 +263,19 @@ static struct console sclp_console = .index = 0 /* ttyS0 */ }; +/* + * Release allocated pages. + */ +static void __init __sclp_console_free_pages(void) +{ + struct list_head *page, *p; + + list_for_each_safe(page, p, &sclp_con_pages) { + list_del(page); + free_page((unsigned long)page); + } +} + /* * called by console_init() in drivers/char/tty_io.c at boot-time. */ @@ -282,6 +295,10 @@ sclp_console_init(void) /* Allocate pages for output buffering */ for (i = 0; i < sclp_console_pages; i++) { page = (void *) get_zeroed_page(GFP_KERNEL | GFP_DMA); + if (!page) { + __sclp_console_free_pages(); + return -ENOMEM; + } list_add_tail(page, &sclp_con_pages); } sclp_conbuf = NULL; -- 2.39.5