Re: [PATCH v2 07/14] s390: Handle KCOV __init vs inline mismatches

Heiko Carstens
2025-05-23T09:36:28Z

On Thu, May 22, 2025 at 09:39:17PM -0700, Kees Cook wrote:
> When KCOV is enabled all functions get instrumented, unless
> the __no_sanitize_coverage attribute is used. To prepare for
> __no_sanitize_coverage being applied to __init functions, we have to
> handle differences in how GCC's inline optimizations get resolved. For
> s390 this exposed a place where the __init annotation was missing but
> ended up being "accidentally correct". Fix this cases and force a couple
> functions to be inline with __always_inline.
>
> Signed-off-by: Kees Cook <kees@kernel.org>
> ---
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
> Cc: Gaosheng Cui <cuigaosheng1@huawei.com>
> Cc: <linux-s390@vger.kernel.org>
> ---
> arch/s390/hypfs/hypfs.h | 2 +-
> arch/s390/hypfs/hypfs_diag.h | 2 +-
> arch/s390/mm/init.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)

Acked-by: Heiko Carstens <hca@linux.ibm.com>