From: Heiko Carstens <hca@linux.ibm.com>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
S390 ML <linux-s390@vger.kernel.org>
Subject: Re: [PATCH] s390/boot: use the full title of the manual for facility bits
Date: Wed, 18 Jun 2025 11:33:17 +0200 [thread overview]
Message-ID: <20250618093317.7535E78-hca@linux.ibm.com> (raw)
In-Reply-To: <20250616163248.77951-1-xose.vazquez@gmail.com>
On Mon, Jun 16, 2025 at 06:32:47PM +0200, Xose Vazquez Perez wrote:
> Also indicate the name of the section where they are listed, because it has a
> length of 2124 pages:
> z/Architecture Principles of Operation - Facility Indications
>
> The current version is: Fourteenth Edition (May, 2022) SA22-7832-13
>
> Cc: Heiko Carstens <hca@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
> Cc: Vasily Gorbik <gor@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
> Cc: Alexander Gordeev <agordeev@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com> (reviewer:S390 ARCHITECTURE)
> Cc: Sven Schnelle <svens@linux.ibm.com> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
> Cc: S390 ML <linux-s390@vger.kernel.org> (open list:S390 ARCHITECTURE)
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> arch/s390/boot/als.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/boot/als.c b/arch/s390/boot/als.c
> index 79afb5fa7f1f..7d4cec1975c6 100644
> --- a/arch/s390/boot/als.c
> +++ b/arch/s390/boot/als.c
> @@ -65,7 +65,7 @@ static void facility_mismatch(void)
> boot_emerg("The Linux kernel requires more recent processor hardware\n");
> boot_emerg("Detected machine-type number: %4x\n", id.machine);
> print_missing_facilities();
> - boot_emerg("See Principles of Operations for facility bits\n");
> + boot_emerg("For facility bits, see: z/Architecture Principles of Operation - Facility Indications\n");
Fine with me, but please let's shorten this to:
boot_emerg("See z/Architecture Principles of Operation - Facility Indications\n");
No need to resend, I guess Alexander can change this if he agrees.
Acked-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2025-06-18 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 16:32 [PATCH] s390/boot: use the full title of the manual for facility bits Xose Vazquez Perez
2025-06-18 9:33 ` Heiko Carstens [this message]
2025-06-18 11:43 ` Alexander Gordeev
2025-07-03 7:59 ` Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618093317.7535E78-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).