From: Michal Luczaj <mhal@rbox.co>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
David Ahern <dsahern@kernel.org>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Jan Karcher <jaka@linux.ibm.com>,
"D. Wythe" <alibuda@linux.alibaba.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
Michal Luczaj <mhal@rbox.co>
Subject: [PATCH net-next v2 9/9] net: skbuff: Drop unused @skb
Date: Thu, 26 Jun 2025 10:33:42 +0200 [thread overview]
Message-ID: <20250626-splice-drop-unused-v2-9-3268fac1af89@rbox.co> (raw)
In-Reply-To: <20250626-splice-drop-unused-v2-0-3268fac1af89@rbox.co>
Since its introduction in commit 6fa01ccd8830 ("skbuff: Add pskb_extract()
helper function"), pskb_carve_frag_list() never used the argument @skb.
Drop it and adapt the only caller.
No functional change intended.
Signed-off-by: Michal Luczaj <mhal@rbox.co>
---
net/core/skbuff.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index b5f685b6611c177c199f70bb16fd3940bce8cded..f8553c674fe5052e7c1ea53022e252a54a9d6c72 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -6756,8 +6756,7 @@ static int pskb_carve(struct sk_buff *skb, const u32 off, gfp_t gfp);
/* carve out the first eat bytes from skb's frag_list. May recurse into
* pskb_carve()
*/
-static int pskb_carve_frag_list(struct sk_buff *skb,
- struct skb_shared_info *shinfo, int eat,
+static int pskb_carve_frag_list(struct skb_shared_info *shinfo, int eat,
gfp_t gfp_mask)
{
struct sk_buff *list = shinfo->frag_list;
@@ -6862,7 +6861,7 @@ static int pskb_carve_inside_nonlinear(struct sk_buff *skb, const u32 off,
skb_clone_fraglist(skb);
/* split line is in frag list */
- if (k == 0 && pskb_carve_frag_list(skb, shinfo, off - pos, gfp_mask)) {
+ if (k == 0 && pskb_carve_frag_list(shinfo, off - pos, gfp_mask)) {
/* skb_frag_unref() is not needed here as shinfo->nr_frags = 0. */
if (skb_has_frag_list(skb))
kfree_skb_list(skb_shinfo(skb)->frag_list);
--
2.49.0
next prev parent reply other threads:[~2025-06-26 8:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 8:33 [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 1/9] net: splice: Drop unused @pipe Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 2/9] net: splice: Drop unused @flags Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 3/9] tcp: Drop tcp_splice_state::flags Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 4/9] af_unix: Drop unix_stream_read_state::splice_flags Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 5/9] net: splice: Drop unused @gfp Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 6/9] net: splice: Drop nr_pages_max initialization Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 7/9] net/smc: " Michal Luczaj
2025-06-26 13:25 ` Sidraya Jayagond
2025-06-27 11:45 ` Simon Horman
2025-06-27 12:59 ` Dust Li
2025-06-26 8:33 ` [PATCH net-next v2 8/9] net: skbuff: Drop unused @skb Michal Luczaj
2025-06-26 8:33 ` Michal Luczaj [this message]
2025-06-26 11:19 ` [PATCH net-next v2 9/9] " Simon Horman
2025-07-01 1:18 ` [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c Jakub Kicinski
2025-07-01 7:27 ` Michal Luczaj
2025-07-01 9:02 ` Paolo Abeni
2025-07-01 23:52 ` Jakub Kicinski
2025-07-02 13:44 ` Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626-splice-drop-unused-v2-9-3268fac1af89@rbox.co \
--to=mhal@rbox.co \
--cc=alibuda@linux.alibaba.com \
--cc=andrew+netdev@lunn.ch \
--cc=ayush.sawal@chelsio.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=horms@kernel.org \
--cc=jaka@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).