From: Eric Biggers <ebiggers@kernel.org>
To: Ingo Franzki <ifranzki@linux.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Harald Freudenberger <freude@linux.ibm.com>,
Holger Dengler <dengler@linux.ibm.com>,
linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: Syzbot finding: invalid-load in arch/s390/crypto/sha_common.c
Date: Thu, 26 Jun 2025 10:34:41 -0700 [thread overview]
Message-ID: <20250626173441.GA1207@sol> (raw)
In-Reply-To: <12740696-595c-4604-873e-aefe8b405fbf@linux.ibm.com>
On Thu, Jun 26, 2025 at 03:54:58PM +0200, Ingo Franzki wrote:
> Hi Eric, Herbert,
>
> There is a Syzbot finding in arch/s390/crypto/sha_common.c.
> Yes that's s390 specific code, but I guess its due to the recent changes in the digest code....
>
> Seems that field first_message_part (bool) of struct s390_sha_ctx has an invalid value when s390_sha_update_blocks() gets called.
> No idea why it could have an invalid value, I only see it being set to 0 or 1. Maybe ctx is pointing to an entirely wrong context in that call chain (bad pointer)?
>
> Does this ring a bell for you?
>
> Status: reporting: reported C repro on 2025/06/09 15:22
> Reported-by: syzbotz+cb049f03e0851197b31a@linux.ibm.com
> First crash: 16d, last: now
This is an issue in hmac_s390_sha512, which I haven't touched. I see there were
recent changes to it, though:
commit 89490e6b80c53bf7783fe183a2fda8d0944f52d2
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue Apr 29 16:49:32 2025 +0800
crypto: s390/hmac - Extend hash length counters to 128 bits
commit 08811169ac016a234765e23deb45a5c8dd8aee6b
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri May 2 17:00:43 2025 +0800
crypto: s390/hmac - Use API partial block handling
commit 1b39bc4a703a63a22c08232015540adfb31f22ba
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri May 23 19:24:34 2025 +0800
crypto: s390/hmac - Fix counter in export state
- Eric
next prev parent reply other threads:[~2025-06-26 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 13:54 Syzbot finding: invalid-load in arch/s390/crypto/sha_common.c Ingo Franzki
2025-06-26 17:34 ` Eric Biggers [this message]
2025-06-26 23:13 ` Eric Biggers
2025-06-27 7:13 ` Ingo Franzki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626173441.GA1207@sol \
--to=ebiggers@kernel.org \
--cc=dengler@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=ifranzki@linux.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).