From: Simon Horman <horms@kernel.org>
To: Michal Luczaj <mhal@rbox.co>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
David Ahern <dsahern@kernel.org>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Jan Karcher <jaka@linux.ibm.com>,
"D. Wythe" <alibuda@linux.alibaba.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH net-next v2 7/9] net/smc: Drop nr_pages_max initialization
Date: Fri, 27 Jun 2025 12:45:48 +0100 [thread overview]
Message-ID: <20250627114548.GA1943@horms.kernel.org> (raw)
In-Reply-To: <20250626-splice-drop-unused-v2-7-3268fac1af89@rbox.co>
On Thu, Jun 26, 2025 at 10:33:40AM +0200, Michal Luczaj wrote:
> splice_pipe_desc::nr_pages_max was initialized unnecessarily in
> commit b8d199451c99 ("net/smc: Allow virtually contiguous sndbufs or RMBs
> for SMC-R"). Struct's field is unused in this context.
>
> Remove the assignment. No functional change intended.
>
> Suggested-by: Simon Horman <horms@kernel.org>
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-06-27 11:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 8:33 [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 1/9] net: splice: Drop unused @pipe Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 2/9] net: splice: Drop unused @flags Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 3/9] tcp: Drop tcp_splice_state::flags Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 4/9] af_unix: Drop unix_stream_read_state::splice_flags Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 5/9] net: splice: Drop unused @gfp Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 6/9] net: splice: Drop nr_pages_max initialization Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 7/9] net/smc: " Michal Luczaj
2025-06-26 13:25 ` Sidraya Jayagond
2025-06-27 11:45 ` Simon Horman [this message]
2025-06-27 12:59 ` Dust Li
2025-06-26 8:33 ` [PATCH net-next v2 8/9] net: skbuff: Drop unused @skb Michal Luczaj
2025-06-26 8:33 ` [PATCH net-next v2 9/9] " Michal Luczaj
2025-06-26 11:19 ` Simon Horman
2025-07-01 1:18 ` [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c Jakub Kicinski
2025-07-01 7:27 ` Michal Luczaj
2025-07-01 9:02 ` Paolo Abeni
2025-07-01 23:52 ` Jakub Kicinski
2025-07-02 13:44 ` Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627114548.GA1943@horms.kernel.org \
--to=horms@kernel.org \
--cc=alibuda@linux.alibaba.com \
--cc=andrew+netdev@lunn.ch \
--cc=ayush.sawal@chelsio.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).