* [PATCH] s390/sclp_tty: Use macros for hardcoded values
@ 2025-07-09 16:38 Xose Vazquez Perez
0 siblings, 0 replies; only message in thread
From: Xose Vazquez Perez @ 2025-07-09 16:38 UTC (permalink / raw)
Cc: Xose Vazquez Perez, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle, S390 ML
Similar as in sclp_vt220
Cc: Heiko Carstens <hca@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc: Vasily Gorbik <gor@linux.ibm.com> (maintainer:S390 ARCHITECTURE)
Cc: Alexander Gordeev <agordeev@linux.ibm.com> (maintainer:S390 ARCHITECTURE)
Cc: Christian Borntraeger <borntraeger@linux.ibm.com> (reviewer:S390 ARCHITECTURE)
Cc: Sven Schnelle <svens@linux.ibm.com> (reviewer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc: S390 ML <linux-s390@vger.kernel.org> (open list:S390 ARCHITECTURE)
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
Trivial, but uncompiled!!
---
drivers/s390/char/sclp_tty.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/char/sclp_tty.c b/drivers/s390/char/sclp_tty.c
index 0a92d08830e7..4e06dc70534c 100644
--- a/drivers/s390/char/sclp_tty.c
+++ b/drivers/s390/char/sclp_tty.c
@@ -23,6 +23,11 @@
#include "sclp_rw.h"
#include "sclp_tty.h"
+#define SCLP_TTY_MAJOR TTY_MAJOR
+#define SCLP_TTY_MINOR 64
+#define SCLP_TTY_DRIVER_NAME "sclp_line"
+#define SCLP_TTY_DEVICE_NAME "sclp_line"
+
/*
* size of a buffer that collects single characters coming in
* via sclp_tty_put_char()
@@ -550,10 +555,10 @@ sclp_tty_init(void)
tty_port_init(&sclp_port);
- driver->driver_name = "sclp_line";
- driver->name = "sclp_line";
- driver->major = TTY_MAJOR;
- driver->minor_start = 64;
+ driver->driver_name = SCLP_TTY_DRIVER_NAME;
+ driver->name = SCLP_TTY_DEVICE_NAME;
+ driver->major = SCLP_TTY_MAJOR;
+ driver->minor_start = SCLP_TTY_MINOR;
driver->type = TTY_DRIVER_TYPE_SYSTEM;
driver->subtype = SYSTEM_TYPE_TTY;
driver->init_termios = tty_std_termios;
--
2.50.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-07-09 16:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-09 16:38 [PATCH] s390/sclp_tty: Use macros for hardcoded values Xose Vazquez Perez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).