* [PATCH] s390/con3270: Use macros for hardcoded values
@ 2025-07-09 17:13 Xose Vazquez Perez
0 siblings, 0 replies; only message in thread
From: Xose Vazquez Perez @ 2025-07-09 17:13 UTC (permalink / raw)
Cc: Xose Vazquez Perez, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle, S390 ML
Similar as in sclp_vt220
Cc: Heiko Carstens <hca@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc: Vasily Gorbik <gor@linux.ibm.com> (maintainer:S390 ARCHITECTURE)
Cc: Alexander Gordeev <agordeev@linux.ibm.com> (maintainer:S390 ARCHITECTURE)
Cc: Christian Borntraeger <borntraeger@linux.ibm.com> (reviewer:S390 ARCHITECTURE)
Cc: Sven Schnelle <svens@linux.ibm.com> (reviewer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc: S390 ML <linux-s390@vger.kernel.org> (open list:S390 ARCHITECTURE)
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
Trivial, but uncompiled!!
---
drivers/s390/char/con3270.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
index b78b86e8f281..c99d7822b176 100644
--- a/drivers/s390/char/con3270.c
+++ b/drivers/s390/char/con3270.c
@@ -33,6 +33,10 @@
#include "raw3270.h"
#include "keyboard.h"
+#define TTY3270_DRIVER_NAME "tty3270"
+#define TTY3270_DEVICE_NAME "3270/tty"
+#define TTY3270_CONSOLE_NAME "tty3270"
+
#define TTY3270_CHAR_BUF_SIZE 256
#define TTY3270_OUTPUT_BUFFER_SIZE 4096
#define TTY3270_SCREEN_PAGES 8 /* has to be power-of-two */
@@ -2020,8 +2024,8 @@ static int __init tty3270_init(void)
* Entries in tty3270_driver that are NOT initialized:
* proc_entry, set_termios, flush_buffer, set_ldisc, write_proc
*/
- driver->driver_name = "tty3270";
- driver->name = "3270/tty";
+ driver->driver_name = TTY3270_DRIVER_NAME;
+ driver->name = TTY3270_DEVICE_NAME;
driver->major = IBM_TTY3270_MAJOR;
driver->minor_start = RAW3270_FIRSTMINOR;
driver->name_base = RAW3270_FIRSTMINOR;
@@ -2145,7 +2149,7 @@ static struct notifier_block on_reboot_nb = {
};
static struct console con3270 = {
- .name = "tty3270",
+ .name = TTY3270_CONSOLE_NAME,
.write = con3270_write,
.device = con3270_device,
.flags = CON_PRINTBUFFER,
--
2.50.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-07-09 17:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-09 17:13 [PATCH] s390/con3270: Use macros for hardcoded values Xose Vazquez Perez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).