From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2E827A46A for ; Tue, 16 Sep 2025 20:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.153.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758053129; cv=none; b=UE+hwloibt4D+YAlDCgrP11gwbII3mwMHYtJjMwrLWYLZDhoJNa2A5QFw4Ok+iU8Im/161ps5OOyZQcExR5QYMLwxGmPIZ5AGKxqEqnHHlowDUnruZinKV28hGRQLkDzfLGgthm2ceZLJJfE5vge0hZr5f7DaKA/9admA78SHl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758053129; c=relaxed/simple; bh=vnrE+dyl2rRA5eCeOVgPqXiQqDXSo5McHniq6JuTE/c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DQC7MHQUYLY41oi/7ymgPmf2l2EFkZvifqNKhG9AsfNkdthyIK3Jq/JZgHXpV72wOtrDYEizXlf7D/jHbD8aLcOsPz+axLyLkR+0vvrpAWFF6GxD1fI/tIt3qr/XyJ+T1WNiQosPJD4JHOWYrvTugYVy0ZrMxwutqL1SCd4Etgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com; spf=pass smtp.mailfrom=meta.com; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b=kYRYZKEw; arc=none smtp.client-ip=67.231.153.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=meta.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b="kYRYZKEw" Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 58GHqm5X1902738 for ; Tue, 16 Sep 2025 13:05:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=s2048-2025-q2; bh=Mgv3SwgS0ByeocJhd6u/6Ox324l7E+OKhpc3GP5WOVQ=; b=kYRYZKEwT4HS NI6wh3gLIzJ9lkkRNhKBpS85NtlXzayZeIlyGis75vourUzy5ifF7+RizBV+BiIC TFHNMnBdPmYnPPz6boje2SkqAMGXCc52U9Xp+BD+h0KB124EKZz5BPtBNIKOHxtO 0AdGztM1BqESxZAhOiO+22I7jCFgw6HqWofi2r78XTb46STAvoyOxyMuAYtzGrab PlSJfvbVKm7No98nn2GD9GIMb/+/ZRhId33sbvnf+w71cWaVU7GfsZo57moaAvTN yGgQDR8GV1Bn1ay9PBcKm7J2dwUeWO+e6rwEFD6Ixq3a6bWzrJaCJhaBucnZiSBV k5MHK6yr8w== Received: from maileast.thefacebook.com ([163.114.135.16]) by m0001303.ppops.net (PPS) with ESMTPS id 497avej73u-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 16 Sep 2025 13:05:26 -0700 (PDT) Received: from twshared45213.02.ash8.facebook.com (2620:10d:c0a8:1b::30) by mail.thefacebook.com (2620:10d:c0a9:6f::8fd4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.20; Tue, 16 Sep 2025 20:05:25 +0000 Received: by devbig091.ldc1.facebook.com (Postfix, from userid 8731) id E654526805CD; Tue, 16 Sep 2025 12:49:18 -0700 (PDT) From: Chris Mason To: Lorenzo Stoakes CC: Chris Mason , Andrew Morton , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , David Rientjes , Shakeel Butt , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Masami Hiramatsu , Oleg Nesterov , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Jason Gunthorpe , John Hubbard , Peter Xu , Jann Horn , Pedro Falcato , Matthew Wilcox , Mateusz Guzik , , , , , , , Subject: Re: [PATCH 02/10] mm: convert core mm to mm_flags_*() accessors Date: Tue, 16 Sep 2025 12:49:13 -0700 Message-ID: <20250916194915.1395712-1-clm@meta.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <1eb2266f4408798a55bda00cb04545a3203aa572.1755012943.git.lorenzo.stoakes@oracle.com> References: Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: mVBJGVfrHJ1gLNQD0kc9zTwdmPflBK2x X-Proofpoint-ORIG-GUID: mVBJGVfrHJ1gLNQD0kc9zTwdmPflBK2x X-Authority-Analysis: v=2.4 cv=aNjwqa9m c=1 sm=1 tr=0 ts=68c9c306 cx=c_pps a=MfjaFnPeirRr97d5FC5oHw==:117 a=MfjaFnPeirRr97d5FC5oHw==:17 a=yJojWOMRYYMA:10 a=yPCof4ZbAAAA:8 a=aLg_dGqrtwJZ8BkNSCAA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE2MDE4NyBTYWx0ZWRfX991QHBqt9BEQ a8x0d3uyDcoRa7d8dYGw2qqbuh4pGMhwNVBKrp/nzYI5wk4qhY2SNqItI+aVQQgc1IsALIis5LF BPwMYW0V6O9Q7d2XKQbxZtnTZ1Kl1vgzPA/E1OVPVcHNmGRakWfp4PB1k6iKbYasZ1DRt9vekDj UtsBKwKQq8OgQ/aYcsMzqrzIF9BnkpCQeDEBCdYu5eCy4eVA3D6/GVyixmzckvj5eD6cLXKTCAa 5ewXyilgUCap72sb312P0TZ9TASfjaRxPJJrbeafAw2h/H622VZmiLibo3NsdOxE54oH6QKvtv5 687KX+UD0DJgzjNkHr/P9TNg/3wZYxMcCljjVjVW3EVKMInv/Rs4pgC3YK+lDM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-16_02,2025-09-16_01,2025-03-28_01 On Tue, 12 Aug 2025 16:44:11 +0100 Lorenzo Stoakes wrote: > As part of the effort to move to mm->flags becoming a bitmap field, con= vert > existing users to making use of the mm_flags_*() accessors which will, = when > the conversion is complete, be the only means of accessing mm_struct fl= ags. >=20 > This will result in the debug output being that of a bitmap output, whi= ch > will result in a minor change here, but since this is for debug only, t= his > should have no bearing. >=20 > Otherwise, no functional changes intended. >=20 > Signed-off-by: Lorenzo Stoakes [ ... ] > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 25923cfec9c6..17650f0b516e 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c [ ... ] > @@ -1251,7 +1251,7 @@ SYSCALL_DEFINE2(process_mrelease, int, pidfd, uns= igned int, flags) > * Check MMF_OOM_SKIP again under mmap_read_lock protection to ensure > * possible change in exit_mmap is seen > */ > - if (!test_bit(MMF_OOM_SKIP, &mm->flags) && !__oom_reap_task_mm(mm)) > + if (mm_flags_test(MMF_OOM_SKIP, mm) && !__oom_reap_task_mm(mm)) > ret =3D -EAGAIN; > mmap_read_unlock(mm); > =20 Hi Lorzeno, I think we lost a ! here. claude found enough inverted logic in moved code that I did a new run wit= h a more explicit prompt for it, but this was the only new hit. -chris