Re: [PATCH v1 6/6] iommu: Pass in old domain to attach_dev callback functions

Nicolin Chen
2025-10-15T17:35:39Z

On Sun, Oct 12, 2025 at 04:57:42PM -0700, Nicolin Chen wrote:
> diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
> index aa576736d60ba..366e47978ac07 100644
> --- a/drivers/iommu/s390-iommu.c
> +++ b/drivers/iommu/s390-iommu.c
> @@ -670,7 +670,8 @@ int zpci_iommu_register_ioat(struct zpci_dev *zdev, u8 *status)
> }
>
> static int blocking_domain_attach_device(struct iommu_domain *domain,
> - struct device *dev)
> + struct device *dev,
> + struct iommu_domain *old)
> {
> struct zpci_dev *zdev = to_zpci_dev(dev);
> struct s390_domain *s390_domain;
> @@ -694,7 +695,8 @@ static int blocking_domain_attach_device(struct iommu_domain *domain,
> }
>
> static int s390_iommu_attach_device(struct iommu_domain *domain,
> - struct device *dev)
> + struct device *dev,
> + struct iommu_domain *old)
> {
> struct s390_domain *s390_domain = to_s390_domain(domain);
> struct zpci_dev *zdev = to_zpci_dev(dev);
> @@ -1131,7 +1133,8 @@ static int __init s390_iommu_init(void)
> subsys_initcall(s390_iommu_init);
>
> static int s390_attach_dev_identity(struct iommu_domain *domain,
> - struct device *dev)
> + struct device *dev,
> + struct iommu_domain *old)
> {
> struct zpci_dev *zdev = to_zpci_dev(dev);
> u8 status;

kernel test robot complains a build break..

Both s390_iommu_attach_device and s390_attach_dev_identity calls
the updated blocking_domain_attach_device function but are not
updated.

I will fix and send v2.

Thanks
Nicolin